fix: update LXD docs URL in firewall warning messages and tests - #974
Draft
dmitry-lyfar with Copilot wants to merge 2 commits into
Draft
fix: update LXD docs URL in firewall warning messages and tests#974dmitry-lyfar with Copilot wants to merge 2 commits into
dmitry-lyfar with Copilot wants to merge 2 commits into
Conversation
Co-authored-by: dmitry-lyfar <69887876+dmitry-lyfar@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job unit-tests / race
fix: update LXD docs URL in firewall warning messages and tests
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LXD documentation moved from
documentation.ubuntu.com/lxd/tocanonical.com/lxd/docs/. ThefirewallDocLinkconstant and its inline comment infirewall.gostill referenced the old domain, causing three tests infirewall_test.goto fail as they matched against.*documentation.ubuntu.com.*.Changes:
internal/workshop/lxd/firewall.go: updatefirewallDocLinkconstant and comment tohttps://canonical.com/lxd/docs/latest/howto/network_bridge_firewalld/internal/workshop/lxd/firewall_test.go: update URL regex assertions inTestBridgeBlockedWarningDocker,TestBridgeBlockedWarningUFW, andTestBridgeBlockedWarningUnknownto match.*canonical.com/lxd/docs.*Self-review quick check
Docs