Skip to content

fix: update LXD docs URL in firewall warning messages and tests - #974

Draft
dmitry-lyfar with Copilot wants to merge 2 commits into
mainfrom
copilot/fix-failing-unit-tests-race
Draft

fix: update LXD docs URL in firewall warning messages and tests#974
dmitry-lyfar with Copilot wants to merge 2 commits into
mainfrom
copilot/fix-failing-unit-tests-race

Conversation

Copilot AI commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

LXD documentation moved from documentation.ubuntu.com/lxd/ to canonical.com/lxd/docs/. The firewallDocLink constant and its inline comment in firewall.go still referenced the old domain, causing three tests in firewall_test.go to fail as they matched against .*documentation.ubuntu.com.*.

Changes:

  • internal/workshop/lxd/firewall.go: update firewallDocLink constant and comment to https://canonical.com/lxd/docs/latest/howto/network_bridge_firewalld/
  • internal/workshop/lxd/firewall_test.go: update URL regex assertions in TestBridgeBlockedWarningDocker, TestBridgeBlockedWarningUFW, and TestBridgeBlockedWarningUnknown to match .*canonical.com/lxd/docs.*

Self-review quick check

  • Make decisions that cost a lot to reverse explicit in the PR description.
  • Avoid nested conditions.
  • Delete dead code and redundant comments.
  • Normalise symmetries by sticking to doing identical things identically.
// one way to handle errors
if err := f(); err != nil {
   ...
}

// one way to handle multiple returns
val, err := f()
if err != nil {
   ...
}
...
  • Check that coupled code elements, files, and directories are adjacent. For example, test data is stored as close as possible to a test.
  • Put variable declaration and initialisation together.
  • Divide large expressions into digestable and self-explanatory ones. Use multiple variables if required.
  • Put a blank line between two logically different chunks of code.
  • Follow the style guide for new error messages.

Docs

  • I confirm the PR has no implications for documentation.

Co-authored-by: dmitry-lyfar <69887876+dmitry-lyfar@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix failing GitHub Actions job unit-tests / race fix: update LXD docs URL in firewall warning messages and tests Aug 11, 2026
Copilot AI requested a review from dmitry-lyfar August 11, 2026 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants