Fix release docs still showing snapshot version on GitHub Pages - #126
Draft
carlspring with Copilot wants to merge 1 commit into
Draft
Fix release docs still showing snapshot version on GitHub Pages#126carlspring with Copilot wants to merge 1 commit into
carlspring with Copilot wants to merge 1 commit into
Conversation
Copilot
AI
changed the title
[WIP] Improve versioning when publishing the documentation
Fix release docs still showing snapshot version on GitHub Pages
Mar 15, 2026
… workflow The root cause was that GitHub Actions suppresses cross-workflow triggers when the initiating action uses GITHUB_TOKEN. The release: [published] trigger in deploy-mkdocs.yaml was never fired when create-release.yaml created the release via GITHUB_TOKEN. Fix: - create-release.yaml: add pages/id-token permissions, expose release_version as job output, add deploy-docs job that checks out the release tag and builds/deploys docs with DOCS_VERSION set to the release version - deploy-mkdocs.yaml: remove non-functional release trigger and the associated Determine docs version step; keep only push-based snapshot deployment Co-authored-by: carlspring <1436265+carlspring@users.noreply.github.com>
carlspring
force-pushed
the
copilot/improve-documentation-versioning
branch
from
March 20, 2026 21:12
c065e05 to
afa852e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a release, GitHub Pages continued to show the pre-release snapshot version (e.g.
1.0.0-rc-5-SNAPSHOTinstead of1.0.0-rc-5). Therelease: [published]trigger added in #125 was silently a no-op: GitHub Actions does not fire cross-workflow events when the triggering action usesGITHUB_TOKEN— sodeploy-mkdocs.yamlnever ran for releases.Changes
create-release.yamlpages: writeandid-token: writepermissionsrelease_versionas a job output from thereleasejobdeploy-docsjob (runs afterrelease) that checks out the release tag, builds docs withDOCS_VERSIONset to the tag, and deploys to GitHub Pages — self-contained within the same workflow, bypassing theGITHUB_TOKENcross-trigger restriction:deploy-mkdocs.yamlrelease: [published]trigger and the associated "Determine docs version" stepdocs/**/**pushes tomaster, reading the version frompom.xmlas beforeOriginal prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.