Fix Java extractor compilation failure on newer JDKs - #25
Merged
Conversation
Co-authored-by: carlspring <1436265+carlspring@users.noreply.github.com>
Co-authored-by: carlspring <1436265+carlspring@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job build-and-publish (java)
Fix Java extractor compilation failure on newer JDKs
Aug 5, 2026
Co-authored-by: carlspring <1436265+carlspring@users.noreply.github.com>
Co-authored-by: carlspring <1436265+carlspring@users.noreply.github.com>
Co-authored-by: carlspring <1436265+carlspring@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All 3 CodeQL test extractions fail because the test
optionsfiles specify-source 17without a matching-target 17, leaving the extractor's default-target 8in effect. On Java 21+, javac rejects-source 17 -target 8as invalid (target cannot be lower than source).Changes
src/test/ql/test/query-tests/*/options— Added-target 17to all three test options files (InsecureCorsHttpOrigin,InsecureCorsWildcardOrigin,InsecureHttpServer)Since javac uses the last occurrence of each flag, this overrides the extractor's default
-source 8 -target 8with a consistent-source 17 -target 17.