chore(ios): raise minimum iOS version to 16.0 - #666
Open
Zeroupper wants to merge 1 commit into
Open
Conversation
Aligns Podfile platform, IPHONEOS_DEPLOYMENT_TARGET and AppFrameworkInfo.plist MinimumOSVersion, which had drifted apart (15.0 vs 14.0). SwiftPM stays off here: `enable-swift-package-manager: false` is still required because Polar (SPM) and Movesense (CocoaPods) both pull in SwiftProtobuf and duplicate its symbols. Verified with `flutter build ios --no-codesign`.
Collaborator
Author
|
@iarata the SPM blocker here is on the sensing side — |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the app to 4.4.3 and raises the iOS floor to 16.0.
The three places that declare the minimum version had drifted apart — Podfile and
IPHONEOS_DEPLOYMENT_TARGETsaid 15.0 whileAppFrameworkInfo.pliststill said 14.0. All three are now 16.0.SwiftPM stays off.
enable-swift-package-manager: falseinpubspec.yamlis still required. See the blocker below.Verification
Branch as-is (SwiftPM off), clean build:
ios/Podfile.lockchurn from the local pod install was left out of this PR.Blocked: SwiftPM cannot be enabled yet
Flipping
enable-swift-package-manager: trueand running a cleanflutter build ipafails at archive time. Note this does not reproduce withflutter build ios --no-codesign— that path succeeds and hides the problem; the failure only appears in the full archive.Blocking packages, by required minimum:
carp_movesense_flutter0.1.1carp_movesense_packagehealth13.3.2carp_health_packagescreen_state5.0.2carp_mobile_sensinglight5.0.0carp_mobile_sensingpolar7.10.2carp_polar_packageWhy "target supports 13.0" when this PR sets 16.0
The 13.0 does not come from the Xcode project. Every
IPHONEOS_DEPLOYMENT_TARGETinproject.pbxprojis 16.0, the Podfile is 16.0,AppFrameworkInfo.plistis 16.0, andxcodebuild -showBuildSettingsconfirmsIPHONEOS_DEPLOYMENT_TARGET = 16.0.It comes from Flutter's generated SPM manifest,
ios/Flutter/ephemeral/Packages/FlutterGeneratedPluginSwiftPackage/Package.swift, which is emitted with:SwiftPackageManager.updateMinimumDeployment(flutter_tools/lib/src/ios/mac.dart:352) is supposed to rewrite that from the project's build settings, but on Flutter 3.44.6 the manifest is still 13.0 after a clean regenerate. So the SPM platform floor never gets raised and every plugin above 13.0 trips Target Integrity.Worth noting: the SwiftProtobuf duplicate-symbol clash between Polar (SPM) and Movesense (CocoaPods) — the reason originally recorded in the
pubspec.yamlcomment for keeping SwiftPM off — is not what fails today. That may have been fixed upstream, or it is simply masked because the build dies earlier at Target Integrity. It should be re-checked once the platform floor issue is resolved.Not blocking this PR
This PR ships with SwiftPM off, which archives cleanly. The above is what has to be solved before SwiftPM can be turned on in a follow-up.
Separately, these plugins still have no SPM support at all and keep CocoaPods in the build regardless:
audio_streamer,flutter_activity_recognition,flutter_sound,location,oidc_ios,open_settings_plus.