Skip to content

Decode chunked bodies in Carp and report broken framing #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hellerve merged 2 commits into from
Aug 27, 2026
Merged

Decode chunked bodies in Carp and report broken framing #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d25304
Decode chunked bodies in Carp and report broken framing
Aug 26, 2026
ddee6c2
Judge a raw-path transport error against Content-Length
Aug 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,8 @@ For chunked or long-running responses, use `Client.request-stream` to get a
(match (ResponseStream.poll &stream)
(Maybe.Nothing) (break)
(Maybe.Just chunk) (IO.print &chunk)))
(when (Maybe.just? (ResponseStream.error &stream))
(IO.errorln "the response body was truncated"))
(ResponseStream.close stream))
(Result.Error e) (IO.errorln &e))
```
Expand All @@ -82,6 +84,15 @@ For chunked or long-running responses, use `Client.request-stream` to get a
implements the `poll` interface from the
[streams](https://github.com/carpentry-org/streams) library.

`poll` returns `Nothing` at the end of a well-formed body and also when the
framing or the transport failed part-way through it; `ResponseStream.error`
tells the two apart. The buffered request functions (`Client.get`,
`Client.request`, and friends) fold that into their result, so a malformed
chunked body, or a `Content-Length` body that ends short, comes back as
`(Result.Error …)` rather than a short body with a 200 on it. A body delimited
only by the connection closing declares no length to check against, so it is
taken as complete however the connection ends.

### Cookie jar

Use a `CookieJar` to store cookies from responses and replay them on
Expand Down
Loading