Refactor code and address issues #493, #530, #532, #534

[guidanoli]

Continue the work of #533, this PR enriches the root Makefile, making it the reference for the project's name, version, Foundry version, as well as many other project-wide definitions. It also addresses several issues blocking the next alpha release:

• Remove IApplicationForeclosure and IApplicationWithdrawal interfaces: We realized this separation was not benefitial to the code organization. So, we merged them back into the IApplication interface.

• Support withdrawals for applications with zero claims: We used to assume that the machine initial state had an empty accounts drive, and therefore, it wouldn't be necessary to prove its Merkle root in order to validate accounts and execute withdrawal outputs. Now, if the application has zero claims, it uses the template hash when proving the accounts drive Merkle root, seamlessly covering this obscure edge case.

• Make the Foreclosure() event single-emission: This was a request by the node team. The foreclose() function now can only be called once by the guardian.

• Bump Foundry from 1.4.3 to 1.5.1: Benefits from improved test performance and fuzzer hability to finds bugs, new cast erc20 commands, and single-line imports formatting. Clients can already test integration with the new devnet state dump by running make devnet.

• Enrich Makefile and simplify workflow files: The root Makefile now concentrates version definitions and recipes that make the workflows slimmer and more locally reproducible. The version file is now generated through a Forge script and from the version definition in the Makefile.

• Deploy a test USD withdrawal output builder to devnet: Essential for locally testing applications that leverage the initial emergency-withdrawal support for accounts backed by USDC-like tokens. This will simplify the cartesi CLI codebase (see cartesi/cli#486).

---

Closes #493
Closes #530
Closes #532
Closes #534

[Copilot]

Pull request overview

This PR continues the refactor started in #533 by centralizing project-wide definitions (name, version, Foundry version, release recipes) in the root Makefile, while also addressing release blockers around application interface structure, foreclosure semantics, and emergency-withdrawal edge cases (including devnet tooling for USD withdrawals).

Changes:

• Consolidate IApplicationForeclosure + IApplicationWithdrawal back into IApplication, and update contracts/tests accordingly.
• Handle the “zero accepted claims” EW edge case by falling back to the template hash when retrieving the last finalized machine Merkle root; update tests to exercise this path.
• Expand build/release automation: Makefile becomes the source of truth for versions, adds release/coverage/bindings targets, and workflows call these targets; devnet deploys a test USD withdrawal output builder.

Reviewed changes

Copilot reviewed 34 out of 36 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
test/withdrawal/UsdWithdrawalOutputBuilderFactory.t.sol	Import formatting updates for withdrawal output builder tests.
test/util/RollupsTest.sol	Update dev contracts deployment to depend on core suite.
test/util/LibEmulator.sol	Minor refactor/cleanup of Merkle proof helper return handling.
test/util/LibBytes32Array.t.sol	Add revert-path fuzz test for invalid split index.
test/util/ConsensusTestUtils.sol	Switch foreclosure calls to the unified IApplication interface.
test/util/ApplicationCheckerTestUtils.sol	Switch isForeclosed encoding to IApplication and reformat helper signature.
test/portals/ERC721Portal.t.sol	Import formatting update.
test/portals/ERC1155SinglePortal.t.sol	Import formatting update.
test/portals/ERC1155BatchPortal.t.sol	Import formatting update.
test/library/LibUsdAccount.t.sol	Import formatting update.
test/dapp/Application.t.sol	Update tests for unified IApplication, single-emission foreclosure, and template-hash EW fallback simulation.
test/common/Version.t.sol	Switch SemVer validation to new script/utils/SemanticVersioning.sol.
src/withdrawal/UsdWithdrawalOutputBuilderFactory.sol	Import formatting update.
src/library/LibUsdAccount.sol	Import formatting update.
src/devnet/TestFungibleToken.sol	Add mint(to,value) and burn(value) for cast erc20 compatibility.
src/dapp/IApplicationWithdrawal.sol	Remove interface (merged back into IApplication).
src/dapp/IApplicationForeclosure.sol	Remove interface (merged back into IApplication).
src/dapp/IApplication.sol	Merge foreclosure + withdrawal events/errors/APIs into IApplication.
src/dapp/ApplicationChecker.sol	Use IApplication.isForeclosed selector for low-level foreclosure checks.
src/dapp/Application.sol	Enforce single-call foreclosure and add template-hash fallback when no claim finalized.
src/common/CanonicalMachine.sol	Import formatting update.
script/utils/SemanticVersioning.sol	Add semver pre-release/build-metadata validators for codegen/test use.
script/utils/DevContracts.sol	Deploy a test USD withdrawal output builder on devnet (depends on core factory + test token).
script/utils/CoreContracts.sol	Import formatting update.
script/utils/ContractDeployers.sol	Add deploy helper for UsdWithdrawalOutputBuilder and extra post-deploy code assertions.
script/Deployment.s.sol	Pass core suite into dev deployment for devnet.
script/CodeGeneration.s.sol	Extend codegen helpers; add generator for Version.sol.
README.md	Update documented Foundry version to 1.5.1.
Makefile	Centralize project/version/foundry definitions; add coverage/release/bindings targets; streamline deploy/devnet.
foundry.toml	Allow writing generated Version.sol; enable single-line imports and docs style.
.gitignore	Ignore dist/ release output directory.
.github/workflows/upload-rust-bindings.yml	Use make rust-bindings instead of duplicating flags in workflow.
.github/workflows/upload-contracts.yml	Use make publish-soldeer-package.
.github/workflows/upload-artifacts.yml	Use make release-artifacts and upload dist/*.
.github/workflows/check-generated-code.yml	Also enforce that src/common/Version.sol is in sync with generator.
.github/actions/setup/action.yml	Read Foundry version from Makefile and bump foundry-toolchain action version.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[endersonmaia]

For consistency, I suggest using either the full chain name always or the shortname.

Or this, all short:

ARB_MAINNET
ARB_SEPOLIA
BASE_MAINNET
BASE_SEPOLIA
ETH_MAINNET
ETH_SEPOLIA
OP_MAINNET
OP_SEPOLIA

Or this, full name:

ARBITRUM_MAINNET
ARBITRUM_SEPOLIA
BASE_MAINNET
BASE_SEPOLIA
ETHEREUM_MAINNET
ETHEREUM_SEPOLIA
OPTIMISM_MAINNET
OPTIMISM_SEPOLIA

I prefer the first (short ones), where I use for the infra and also follow Alchemy's URL naming.

[guidanoli]

Good idea. Let's use the short ones.