Drop faraday_middleware, allow Faraday 2.x (1.1.1) - #16
Merged
Conversation
faraday_middleware is deprecated upstream and will never ship a Faraday 2 compatible release. It was only pulled in here for :gzip - :json (request and response) and :raise_error are already core Faraday middleware, no gem needed for those. Replaces :gzip with the faraday-gzip gem (pinned ~> 2.0, which supports faraday >= 1.0), and relaxes the faraday dependency itself from ~> 1 to >= 1, < 3. Verified by running the full spec suite and standardrb against both Faraday 1.10.6 (default resolution) and 2.14.3 (forced via `bundle update faraday`): 34 examples, 0 failures, clean lint on both. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
Author
|
The CircleCI failure here is a pre-existing infra issue, unrelated to this change: it fails at the git checkout step with Confirmed this predates the PR:
This means the project's CircleCI checkout SSH key/GitHub App integration needs to be re-added by someone with CircleCI project-admin access — it would fail on any commit right now, not just this one. Locally, the full spec suite + standardrb pass cleanly against both Faraday 1.10.6 and 2.14.3 (see PR description). |
PChambino
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
faraday_middlewareis deprecated upstream and will never ship a Faraday 2 compatible release. It was only pulled in here for:gzip—:json(request and response) and:raise_errorare already core Faraday middleware, no gem needed for those.:gzipwith thefaraday-gzipgem, pinned to~> 2.0(which supportsfaraday >= 1.0).faradayitself from~> 1to>= 1, < 3.Test plan
standardrbagainst Faraday 1.10.6 (default resolution): 34 examples, 0 failures, clean lint.bundle update faradayto force resolution to Faraday 2.14.3, reran both: 34 examples, 0 failures, clean lint.faraday_middlewareno longer appears inbundle list.dealers_site depends on this gem directly and was one of the named hard blockers on the ecosystem Faraday 1→2 migration (Kanbanize card #121677, split from #75150) — this removes it.
🤖 Generated with Claude Code