fix(ci): scoop bucket auto-update never actually ran - #21
Merged
Conversation
.github/workflows/scoop-update.yml (on: release: types: [published]) had zero runs ever, including for v0.7.1 — GitHub does not trigger 'release' events for releases created by a workflow using the default GITHUB_TOKEN (here, softprops/action-gh-release with no explicit token: input), specifically to prevent workflow recursion. This is why 'scoop update zt' kept reporting 0.7.0 as latest after v0.7.1 shipped. Folds the bucket bump into release.yml itself as a step right after the release upload, in the same job — it already has the sha256 on disk from the 'Generate checksums' step, so no second network round-trip or risk of racing the upload. Removes the now-dead scoop-update.yml. Manually bumps bucket/zt.json to v0.7.1 (correct url + hash) since the automated path never fired for it.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
casablanque-code
added a commit
that referenced
this pull request
Aug 2, 2026
Requires patches #20 (newCFClient) and #21 (withFakeCFClient helper, defined in init_test.go) already applied. Drives runDown end to end against a fake server covering every endpoint it hits — zone lookup, DNS record find+delete, Access app find+delete, tunnel delete — and asserts all three deletes actually fired plus the tunnel is gone from local state afterward. runDown never returns an error for an individual step's failure (only prints a warning and keeps going), so 'did everything actually get called' is the only way to catch a regression here — a passing test with a silently-skipped step was the real risk this closes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.github/workflows/scoop-update.yml (on: release: types: [published]) had zero runs ever, including for v0.7.1 — GitHub does not trigger 'release' events for releases created by a workflow using the default GITHUB_TOKEN (here, softprops/action-gh-release with no explicit token: input), specifically to prevent workflow recursion. This is why 'scoop update zt' kept reporting 0.7.0 as latest after v0.7.1 shipped.
Folds the bucket bump into release.yml itself as a step right after the release upload, in the same job — it already has the sha256 on disk from the 'Generate checksums' step, so no second network round-trip or risk of racing the upload. Removes the now-dead scoop-update.yml.
Manually bumps bucket/zt.json to v0.7.1 (correct url + hash) since the automated path never fired for it.