initial implementation of TriangleSelector#1114
Open
henrydingliu wants to merge 1 commit into
Open
Conversation
henrydingliu
requested review from
genedan,
jbogaardt and
kennethshsu
as code owners
July 13, 2026 05:52
Pyright Type CompletenessView the full Project (full
Other symbols referenced but not exported by
Symbols without documentation:
Patch (exported symbols added or changed by this PR): 25.0% fully typed (2 / 8)
Patch symbol details
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1114 +/- ##
==========================================
+ Coverage 90.50% 90.55% +0.04%
==========================================
Files 91 91
Lines 5289 5306 +17
Branches 671 672 +1
==========================================
+ Hits 4787 4805 +18
Misses 359 359
+ Partials 143 142 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
New workflow step for combining incurred/paid into a single VotingChainladder estimator
Related GitHub Issue(s)
helps with various chapters of #588
Additional Context for Reviewers
uv run pytest) and documentation changes (uv run jb build docs --builder=custom --custom-builder=doctest)Note
Medium Risk
Changes how VotingChainladder combines weighted ultimates, which affects ensemble reserving results whenever column dimensions differ across estimators.
Overview
Adds
TriangleSelector, a sklearn-style pipeline step that narrows aTriangleto a single column (e.g. paid vs incurred) so each branch of aVotingChainladdercan run on different measures from the same input.VotingChainladderblending in_get_ultimateis updated so weighted combinations use each estimator’sultimate_shape instead of assuming it matches the full input triangle; mismatched shapes raise aValueErrorwith a hint aboutTriangleSelector. The class is exported fromchainladderand covered by workflow tests plus the public API guard.Reviewed by Cursor Bugbot for commit dfba575. Bugbot is set up for automated code reviews on this repo. Configure here.