Remove old style explicit kernel names from tests - #340
Merged
Conversation
|
Check-perf-impact results: (ae6918621b46271c2f10d6eb978fe95d) ❓ No new benchmark data submitted. ❓ |
PeterTh
approved these changes
Aug 11, 2026
Coverage Report for CI Build 31489551368Coverage decreased (-0.02%) to 95.052%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After some investigation and discussion, we found that the old
UKN(...)macro generates identical kernel names for different translation units (TUs) when running the tests on Windows. This causes the./all_testsexecutable to fail when testing with SimSYCL.In an offline discussion with @PeterTh, we decided to remove the
UKN(...)macro entirely. SYCL no longer requires explicit kernel names, and all major SYCL implementations support the code without this macro out of the box.