feat: discovery-first tool resolution (make Mason optional)

[charliie-dev]

Discovery-first tool resolution: for LSP servers, formatters, linters, and DAP
adapters, a tool on $PATH is used as-is; else Mason installs it when it ships a
package; else an aggregated warning asks you to provision it. Mason becomes an
optional backend rather than a hard dependency.

History aggregated into six thematic commits (resolver core, LSP, conform, lint,
DAP, settings). Final tree is byte-identical to the fully-reviewed work from the
prior branch — this supersedes #21, which GitHub locked as merged after an
accidental merge+reset (the merge was reverted on main).

Verification: stylua + selene clean; the discovery-first behavior was validated
by an extensive headless test fleet and four rounds of Copilot review (all
findings addressed) on the prior branch state.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a37d44f765

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[Copilot]

Pull request overview

Implements a shared “discovery-first” tool resolution layer across the config so executables found on $PATH are used immediately, Mason becomes an optional installer backend, and missing/unknown tools are aggregated into a single actionable warning per subsystem.

Changes:

• Add a new shared resolver (modules.utils.tools) that drives discovery → optional Mason install → aggregated warnings + retry hooks.
• Refactor LSP, DAP, conform formatters, and nvim-lint linters to use the shared resolver and to avoid loading Mason unless needed.
• Update settings and filetype/schema plumbing (e.g., yaml.github detection + schema/LS claims) to support the new resolution model.

Reviewed changes

Copilot reviewed 20 out of 20 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
vim.yml	Teach Selene about package.searchpath (LuaJIT extension) used by the new resolver.
lua/modules/utils/tools.lua	New resolver core: executable discovery, optional Mason integration, install tracking, aggregated warnings, and :ToolsRetry.
lua/modules/utils/init.lua	Remove register_server helper in favor of the new LSP resolution/enable flow.
lua/modules/utils/dap.lua	Add shared attach endpoint validation helper and export it alongside existing helpers.
lua/modules/plugins/tool.lua	Make mason-nvim-dap lazy/optional instead of a hard dependency of nvim-dap.
lua/modules/configs/tool/dap/init.lua	Refactor DAP setup to use discovery-first resolution, lazy Mason mapping usage, and robust client-config loading.
lua/modules/configs/tool/dap/clients/python.lua	Switch python adapter to discovery-first debugpy resolution (PATH shim → import-probe cascade) + config validation.
lua/modules/configs/tool/dap/clients/lldb.lua	Resolve LLDB adapter binary discovery-first (lldb-dap/lldb-vscode).
lua/modules/configs/tool/dap/clients/delve.lua	Use dlv dap directly with remote-attach support and discovery-first provisioning signaling.
lua/modules/configs/tool/dap/clients/codelldb.lua	Self-validate codelldb availability at config time using the shared resolver.
lua/modules/configs/completion/servers/yamlls.lua	Expand YAML schema configuration and add a bounded prune to prevent Traefik v2/v3 schema conflicts; explicitly claim dotted filetypes.
lua/modules/configs/completion/servers/shuck.lua	Update comments/semantics to align shuck with discovery-first $PATH resolution.
lua/modules/configs/completion/servers/gh_actions_ls.lua	Add server override to explicitly claim yaml.github (and yaml) filetypes.
lua/modules/configs/completion/nvim-lint.lua	Resolve linter deps discovery-first against nvim-lint’s registry, add late reload handling, and add a parity sweep.
lua/modules/configs/completion/mason.lua	Remove ensure-install loop; keep Mason as UI + event hand-off to the resolver.
lua/modules/configs/completion/mason-lspconfig.lua	Major LSP refactor: recorded user overrides, discovery-first dep resolution, per-filetype batching, and sweep backstop.
lua/modules/configs/completion/lsp.lua	Reorder flow: setup machinery → apply user overrides → resolve deps discovery-first → start LSP.
lua/modules/configs/completion/conform.lua	Factor autoformat gating predicate and add discovery-first formatter dep resolution against conform’s registry.
lua/core/settings.lua	Consolidate LSP deps (remove external_lsp_deps), switch formatter/linter dep naming to subsystem names, add tool_install_timeout, and add migration warning.
ftdetect/github.lua	Add dotted yaml.github filetype detection for GitHub Actions workflows to key tooling off it.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 20 out of 20 changed files in this pull request and generated 1 comment.

[Copilot]

Pull request overview

Copilot reviewed 20 out of 20 changed files in this pull request and generated 2 comments.

[Copilot]

Pull request overview

Copilot reviewed 21 out of 21 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

lua/modules/utils/dap.lua:99

• modules.utils.dap now returns a proxy table whose __index always produces a double-thunk (meant for input_*() helpers). This breaks callers that expect an eager value like utils.get_env() (e.g. LLDB client config sets env = utils.get_env()): get_env() will currently return a function instead of the env table. Export get_env as a concrete function (like attach_endpoint) so it bypasses the __index thunking.

local export = setmetatable({}, {
	-- Lazy nullary double-thunk: `program = utils.input_file_path()` hands
	-- nvim-dap a zero-arg closure. Any key reached through this __index
	-- DISCARDS call arguments — functions that take arguments must be
	-- CONCRETE keys on the export (raw hits bypass __index).
	__index = function(_, key)
		return function()
			return function()
				return M[key]()
			end
		end
	end,
})
export.attach_endpoint = M.attach_endpoint
return export

[Copilot]

Pull request overview

Copilot reviewed 27 out of 27 changed files in this pull request and generated 1 comment.

[Copilot]

Pull request overview

Copilot reviewed 27 out of 27 changed files in this pull request and generated no new comments.

[Copilot]

Pull request overview

Copilot reviewed 27 out of 27 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

lua/modules/configs/completion/nvim-lint.lua:444

• vim.api.nvim_create_autocmd expects opts.group to be an augroup id. Using the string "NvimLint" can throw at runtime and prevent this one-shot FileType catch-up from being registered.

		vim.api.nvim_create_autocmd("FileType", {
			group = "NvimLint",
			buffer = load_buf,
			once = true,
			callback = function()

[Copilot]

Pull request overview

Copilot reviewed 27 out of 27 changed files in this pull request and generated no new comments.