fix(sandbox): rotate stale runtimes safely - #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Promoting the Node 24 snapshot made every existing sandbox permanently return
unavailable_maintenance: lookup detected the old snapshot, but no lifecycle path ever replaced it. This change makes immutable snapshot promotion operational without moving or deleting user workspace data.The replacement decision is intentionally narrow. Snapshot or target drift is recoverable only when the existing resource is unambiguously the user's canonical sandbox on the configured persistent volume. Identity, label, mount, and duplicate-resource ambiguity remain operator-visible failures.
Verification
pnpm turbo lint typecheck buildunder Node 24.18.0apps/agent-worker@cheatcode/agent-workergit diff --checkpackages/db/drizzle/0000_current_schema.sqlProduction upload/persistence acceptance QA will run directly through
agent-browserafter the exact merged revision is deployed.