refactor: repo-wide deslop (net −51.8k lines) - #92
Merged
Conversation
…edupe research workflows
…e, lease-policy facade
…nconsumed openapi subsystem
…s docs, harden deadcode gate
…s + upload path guards into lease-policy facade)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Full-repo deslop: net −51,800 lines (−24%), 146 files removed, executed as seven gate-verified waves plus an adversarial regression-review pass.
What changed
skills/{docx,pptx,xlsx}/scripts/officewere byte-identical; one copy now lives atskills/_shared/officeand the sandbox Dockerfile materializes all three paths at image build.pnpm turbo skills:buildoutput is byte-identical.packages/dbrestructured: the hand-maintainedsupabase-target*schema mirror (2,904 LOC) became a 720-LOC migration smoke+invariant gate underscripts/supabase-target/; the three lease-queue implementations share one generic core (SQL semantics preserved op-by-op); research workflows deduplicated./v1/tools,/v1/agents, sandbox file API replaced by the code-server IDE,runs/status), write-only stream parts (schemas retained for historical transcripts), 55% of web CSS, single-use wrappers, barrel bloat, config husks./pricing+/usage(and drops nonexistent routes); staleapp_workerrole reference removed;SkillRuntimeScopeSchemasingle-sourced in@cheatcode/types.pnpm deadcodenow runs knip withincludeEntryExports(it previously could not flag any dead export) and reports zero findings.Deliberately kept
Gateway idempotency DO layer (an adversarial concurrency trace proved it load-bearing: post-commit/pre-DO-start duplicate-POST race),
api/health, the daily-maintenance activation phase, Ultra/Max env plumbing,generated-manifest.tstracking (Vercel affected-detection).Regression pass
An independent review of the refactor commits found and this branch fixes: gateway error responses losing CORS/security headers (proven fixed live: cross-origin 401 carries ACAO+CSP+HSTS), webhook store outages surfacing 500 instead of retriable 503, a blind row-cast that could permanently drop a webhook, four over-deleted migration invariant validators (restored), preview-proxy leaking
X-Request-Idupstream.Verification
lint/typecheck/turbo build --force(23/23 cold) /deadcode(0 findings) /architecture:check/skills:buildmanifest-stable — all green post-merge withorigin/main(upload-guard +restoreUploadedFileswork ported into the new facade). Live smoke via direct agent-browser: home, signed-out auth redirects for/pricing+/usage, signed-in/usage, historical chat transcript rendering.Deploy notes: sandbox snapshot rebuilds on merge (Dockerfile materialization step); gateway telemetry route labels change format once (analytics series discontinuity).