Fix Construction 2 butler handling - #523
Conversation
f1fd4e4 to
011b9d6
Compare
|
I built the PR's synthetic merge result against Microbot 2.6.19;
The reported Demon Butler/Mahogany Table testing is useful. Once the diff is focused, recovery behavior is covered, and the version is bumped, this should be much safer to merge. |
chsami
left a comment
There was a problem hiding this comment.
The previously reported blockers are unchanged. ConstructionPlugin still has no version bump, the single-file change remains an 847-addition rewrite that mixes servant handling with unrelated build/remove/state refactoring, and the outside-house returnToTheHouse recovery was removed without a validated replacement. The branch is also now far behind development. Please narrow the diff to the servant and bank-trip fix, restore or live-validate recovery, bump the plugin version, and rebase on current development.
|
Requested changes summary: please narrow the 847-addition ConstructionScript rewrite to the servant and bank-trip behavior, restore or live-validate the removed outside-house recovery, bump ConstructionPlugin.version, and rebase on current development. The reported Demon Butler testing is useful, but the current diff is too broad to safely attribute that validation to all changed state/build/remove behavior. |
Summary
Fixes servant handling issues in Construction 2 that could cause the script to become stuck or significantly reduce XP/hr.
The initial issue occurred when the script needed to call the servant. It would open the House Options tab and hover over the Call Servant button, but would always fail to actually click it. This prevented the construction cycle from continuing correctly and could cause the script to stall, resulting in XP/hr rates being cut roughly in half.
While fixing the initial Call Servant issue, additional problems were found with the servant's bank-trip handling. The script could repeatedly attempt to call the servant while he was away at the bank, or fail to properly handle him when he returned with planks.
Changes
Testing
.\gradlew buildcompleted successfully.