-
Notifications
You must be signed in to change notification settings - Fork 0
[PF-26] Fixing planforge doctor errors on Mac #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
84121e5
fix : planforge run in mac os
chucoding 18ef5af
chore : Change the Planforge Doctor TC1 question to one that a real u…
chucoding 5ec5438
chore : improve CI Build error
chucoding ba782bb
fix : python error
chucoding 60764d9
chore : improve CI GuardRail
chucoding 0f2de7c
chore : CRLF => LF
chucoding 2a35006
fix : add codex error process (Authentication/Usage/Execution Failure)
chucoding 961994c
fix : add codex error process (Authentication/Usage/Execution Failure…
chucoding File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| # Shell scripts must use LF so they run on Mac/Linux (e.g. .cursor/skills/*/scripts/*.sh). | ||
| *.sh text eol=lf | ||
| # Cursor rules/skills: keep LF for cross-platform and CI (template–runtime comparison, script execution). | ||
| .cursor/rules/*.mdc text eol=lf | ||
| .cursor/skills/**/*.md text eol=lf | ||
| .cursor/skills/**/*.py text eol=lf | ||
| .cursor/skills/**/*.ps1 text eol=lf | ||
| templates/cursor/rules/*.mdc text eol=lf | ||
| templates/cursor/skills/**/*.md text eol=lf | ||
| templates/cursor/skills/**/*.py text eol=lf | ||
| templates/cursor/skills/**/*.ps1 text eol=lf |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| { | ||
| "tc1PlanRequest": "Give me a plan for this project.", | ||
| "tc1PlanRequest": "I want a plan for a script that prints \"Hello world\".", | ||
| "tc2ImplementRequest": "Implement according to the plan.", | ||
| "tc3SlashPWithImplementationStyleContent": "/p planforge init currently forces init when Claude is installed; change it to ask the user (y/n) whether to run Claude init." | ||
| "tc3SlashPWithImplementationStyleContent": "The user invoked the plan command (/p) with this request: planforge init currently forces init when Claude is installed; change it to ask the user (y/n) whether to run Claude init." | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the non-Windows streaming path, the code writes to
child.stdinwithout handlingstdinstream errors. Ifcodex exec -exits before consuming stdin (for example due to startup/auth/usage failures), Node can emitwrite EPIPEon that stream and terminate the process with an unhandled error, sorunPlan/runImplement/doctor streaming crash instead of surfacing the Codex stderr message.Useful? React with 👍 / 👎.