Skip to content

fix(ci): add missing nightly upgrade workflow - #329

Open
Kewe63 wants to merge 1 commit into
circlefin:mainfrom
Kewe63:fix-324-upgrade-workflow-reference
Open

fix(ci): add missing nightly upgrade workflow#329
Kewe63 wants to merge 1 commit into
circlefin:mainfrom
Kewe63:fix-324-upgrade-workflow-reference

Conversation

@Kewe63

@Kewe63 Kewe63 commented Sep 3, 2026

Copy link
Copy Markdown

Summary

Fixes #324

This adds the missing .github/workflows/nightly-upgrade.yml workflow referenced by scripts/run-upgrade-test.sh.

Previously, the script generated a GitHub CLI command targeting nightly-upgrade.yml:

gh workflow run nightly-upgrade.yml -R circlefin/arc-node --ref main ...

but .github/workflows/nightly-upgrade.yml did not exist, so the generated command pointed to a missing workflow.


Changes

  • Add .github/workflows/nightly-upgrade.yml.
  • Expose workflow_dispatch inputs expected by scripts/run-upgrade-test.sh:
    • from_version
    • to_version
    • hardfork
  • Add optional manual-run parameters:
    • load_duration
    • load_rate
  • Run scripts/scenarios/nightly-upgrade.sh from the workflow.
  • Prepare a temporary scenario TOML with image version overrides before running the scenario.
  • Upload target/test-results as a workflow artifact when available.

Why

scripts/run-upgrade-test.sh is intended to trigger the nightly upgrade workflow remotely with image version overrides. The workflow file needs to exist and accept the same inputs the script sends; otherwise dry-run output looks valid but the actual gh workflow run command cannot succeed.


Verification

Script syntax:

bash -n scripts/run-upgrade-test.sh

Result:

passed

Dry-run command:

bash scripts/run-upgrade-test.sh --remote origin --dry-run --from 0.7.3-dev --to 0.8.0-dev --hardfork zero8

Result:

gh workflow run nightly-upgrade.yml -R circlefin/arc-node --ref main -f from_version=0.7.3-dev -f to_version=0.8.0-dev -f hardfork=zero8

Workflow existence check:

test -f .github/workflows/nightly-upgrade.yml

Result:

passed

Input/reference check:

.github/workflows/nightly-upgrade.yml exists and exposes expected inputs

Formatting:

npx prettier --config ./.prettierrc --check .github/workflows/nightly-upgrade.yml scripts/scenarios/README.md

Result:

All matched files use Prettier code style!

Whitespace check:

git diff --check

Result:

passed


Notes

This PR restores the workflow target that scripts/run-upgrade-test.sh already expects. The workflow keeps the script-facing input names unchanged so existing dry-run and remote trigger usage continue to work.


Checklist

  • Script syntax and dry-run output verified
  • Workflow file exists and exposes expected inputs
  • Prettier clean, git diff --check clean
  • Follows Conventional Commits
  • Changes scoped to this fix only

Risk & Impact

None to low. Purely additive — adds the missing workflow file the script already expected; no existing workflow, script logic, or input names are changed. scripts/run-upgrade-test.sh requires no changes since it already targeted this workflow name and these input names.

Type: 🐛 Bug fix
Fixes: #324

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

run-upgrade-test.sh references missing nightly-upgrade.yml workflow

1 participant