fix(ci): add missing nightly upgrade workflow - #329
Open
Kewe63 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #324
This adds the missing
.github/workflows/nightly-upgrade.ymlworkflow referenced byscripts/run-upgrade-test.sh.Previously, the script generated a GitHub CLI command targeting
nightly-upgrade.yml:gh workflow run nightly-upgrade.yml -R circlefin/arc-node --ref main ...
but
.github/workflows/nightly-upgrade.ymldid not exist, so the generated command pointed to a missing workflow.Changes
.github/workflows/nightly-upgrade.yml.workflow_dispatchinputs expected byscripts/run-upgrade-test.sh:from_versionto_versionhardforkload_durationload_ratescripts/scenarios/nightly-upgrade.shfrom the workflow.target/test-resultsas a workflow artifact when available.Why
scripts/run-upgrade-test.shis intended to trigger the nightly upgrade workflow remotely with image version overrides. The workflow file needs to exist and accept the same inputs the script sends; otherwise dry-run output looks valid but the actualgh workflow runcommand cannot succeed.Verification
Script syntax:
Result:
passed
Dry-run command:
Result:
gh workflow run nightly-upgrade.yml -R circlefin/arc-node --ref main -f from_version=0.7.3-dev -f to_version=0.8.0-dev -f hardfork=zero8
Workflow existence check:
test -f .github/workflows/nightly-upgrade.ymlResult:
passed
Input/reference check:
.github/workflows/nightly-upgrade.yml exists and exposes expected inputs
Formatting:
Result:
All matched files use Prettier code style!
Whitespace check:
Result:
passed
Notes
This PR restores the workflow target that
scripts/run-upgrade-test.shalready expects. The workflow keeps the script-facing input names unchanged so existing dry-run and remote trigger usage continue to work.Checklist
git diff --checkcleanRisk & Impact
None to low. Purely additive — adds the missing workflow file the script already expected; no existing workflow, script logic, or input names are changed.
scripts/run-upgrade-test.shrequires no changes since it already targeted this workflow name and these input names.Type: 🐛 Bug fix
Fixes: #324