fix(decoder): reject DECODER_OPTION_NUM_OF_THREADS after initialization - #3973
Open
HeaTTap wants to merge 1 commit into
Open
fix(decoder): reject DECODER_OPTION_NUM_OF_THREADS after initialization#3973HeaTTap wants to merge 1 commit into
HeaTTap wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3969
When
SetOption(DECODER_OPTION_NUM_OF_THREADS)is called afterISVCDecoder::Initialize(), resettingm_pDecThrCtxwithout re-creating worker threads leaves the decoder in an uninitialized thread context state, causing a deadlock in subsequentDecodeFrameNoDelayorWelsDestroyDecodercalls.This fix returns
cmInitParaErrorifDECODER_OPTION_NUM_OF_THREADSis set post-initialization (m_pDecThrCtx[0].pCtx != NULL), preventing thread context corruption.Added unit test
DecoderInitTest.SetThreadCountPostInitFailsintest/api/decoder_test.cppand verified full test suite passes.