Fix -loadbalancing parsing when used as the final option - #3974
Open
w1boost1889M wants to merge 1 commit into
Open
Fix -loadbalancing parsing when used as the final option#3974w1boost1889M wants to merge 1 commit into
w1boost1889M wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix command-line parsing of the -loadbalancing encoder option when it is placed at the end of the argument list.
Problem
-loadbalancing consumes one value, but its argument availability check currently requires two remaining arguments:
(n + 1 < argc)
As a result, a valid final argument pair such as:
-loadbalancing 0
is silently ignored, leaving the default load-balancing setting enabled.
Fix
Use the same one-argument availability check as the surrounding single-value options:
(n < argc)