Ensure we can remove El Torito from a Windows 11 ISO. - #176
Merged
Conversation
The problem was that the El Torito boot catalog on the Windows 11 ISO did not have any records attached. While this violates the standard, it is a relatively common situation, so we attach a "fake" directory record so that the ISO is conformant. But we forgot to propogate that fix through to rm_eltorito, so if you try to remove El Torito on such an ISO, you can an exception rather than successful removal. The fix is to skip this fake record on such ISOs. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem was that the El Torito boot catalog on the Windows 11 ISO did not have any records attached. While this violates the standard, it is a relatively common situation, so we attach a "fake" directory record so that the ISO is conformant.
But we forgot to propogate that fix through to rm_eltorito, so if you try to remove El Torito on such an ISO, you can an exception rather than successful removal. The fix is to skip this fake record on such ISOs.
This fixes #175