fix(theme): tidy the page bottom on narrow screens - #117
Merged
Merged
Conversation
- The footer's copyright strip set its text on paper-coloured chips over screentone. Once the strip wrapped on a phone, the dots ran between and around the chips; it is now a plain strip under a dashed rule. - On pages with no sidebar and no headings (home, blog, 404), VitePress pins a bar holding only "Return to top" under the navbar once the page scrolls on narrow screens. It is hidden there; doc pages keep their bar with the sidebar menu and outline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two things made the bottom of pages look broken on phones:
.VPLocalNav.fixed. Doc pages keep their bar with the sidebar menu and the outline.Checked in
vitepress devat 390 px on/,/blogand a guide page (the bar is hidden on the first two and still shows Menu / On this page on the guide), and the footer at 1440 px in light and dark.