Conversation
Splits the decision in resync_modifiers_if_stale out as a pure function (which buttons are released, whether remapped_keys/click latch are cleared, whether FlagsChanged is posted) and table-tests it for both triggers, as requested in the clintcan#183 follow-up. No behaviour change. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up requested in #183: a small test for the reconnect reset, split out pure the way
should_remap_clickis.resync_plan(reconnected, buttons_down, mods_held)→ResyncPlan{ release_buttons, clear_gesture_state, post_flags_changed };resync_modifiers_if_stalenow just gathers inputs and performs the effects. No behaviour change.resync_plan_connection_edge_releases_buttons_and_clears_state: which buttons are released, latch/remapped_keyscleared even with no modifier held,FlagsChangedonly when a modifier was held.resync_plan_idle_gap_touches_modifiers_only: idle gap never releases buttons or clears the latch.cargo fmt --check,clippy --all-targets -- -D warningsand the full suite (264 passed) are clean. The live mid-drag disconnect with a real file over a folder is still not done.🤖 Generated with Claude Code