Skip to content

Proposal for fix #88

Description

@lutopastialis

When using the latest unreleased version 2.8.2.1 from the ZIP archive PAL_FlatFiles_2.8.2.1.zip with multiple *.blg files, the GUI wizard silently crashes and an empty *.htm report file with an empty folder is created in the output directory.

When selecting only a single *.blg file it works.

By comparing the PAL.ps1 file with the one from version 2.7.4, where this error doesn't occur, I found the bug and was able to fix it on my machine. The reason I went from 2.7.4 to 2.8.2.1 is the updated .NET Framework version.

Fix

By removing the quotes on line 1157 in PAL.ps1 as shown below, the tool can be successfully used with multiple (consequtive) *.blg files.

Before (broken)

#// Dont filter anymore. Filtering causes problems with counter language translation
$sCommand = $('relog.exe ' + "`"$sTemp`"" + ' -f csv -o ' + "`"$($global:oPal.RelogedLogFilePath)`"")

After (fixed)

#// Dont filter anymore. Filtering causes problems with counter language translation
$sCommand = $('relog.exe ' + $sTemp + ' -f csv -o ' + "`"$($global:oPal.RelogedLogFilePath)`"")

I would have made a PR, but I couldn't find the source PAL.ps1 file in the repo. It seems to be a generated file and I'm not fluent in VB. This might solve a couple of related issues, e.g. #83 and #67.
The fix is tiny and I tested a few times with and without the change and I could reproduce/fix it consistently.

Please consider applying this small fix and creating a new ZIP archive on master.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions