test(server-nestjs): cas limites du module Observability (plugin, client YAML) - #2587
Draft
shikanime wants to merge 3 commits into
Draft
test(server-nestjs): cas limites du module Observability (plugin, client YAML)#2587shikanime wants to merge 3 commits into
shikanime wants to merge 3 commits into
Conversation
…nment Co-authored-by: Automata <automata@shikanime.studio>
Open
10 tasks
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
shikanime
changed the title
…ility specs Signed-off-by: William Phetsinorath <william.phetsinorath-open@interieur.gouv.fr> Change-Id: I35c94382a862ea25935947720c4a05916a6a6964
Annotate the repo const with CondensedProjectSchemaWith<'id'> instead of as unknown as, build the created-repo value via makeProjectSchema instead of as ProjectSchema, and read the commit content arg without as string, per server-nestjs vitest convention. Signed-off-by: William Phetsinorath <william.phetsinorath-open@interieur.gouv.fr> Change-Id: Ia05cf77e80581a7513da8f83fa1604366a6a6964
|
1 New Issue
0 Fixed Issues
0 Accepted Issues
No data about coverage (39.30% Estimated after merge)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues liées
#2574
Quel est le comportement actuel ?
Les services plugin et client du module observability étaient à 11% et 12% de lignes couvertes : le cycle de vie Grafana (URLs par type d'environnement, descripteur de config) et le round-trip YAML du fichier de valeurs n'étaient pas testés.
Quel est le nouveau comportement ?
+2 specs / 28 tests :
observability-plugin.service.spec.ts: URLs hprod/prod selon les stages, erreur projet introuvable, contrat du descripteur (switch global admin-writable, instances read-only) ;observability-client.service.spec.ts: répo values existant/créé, fallback init + clone sûr, garde zod sur YAML invalide, idempotence updateProjectConfig (pas de commit si identique), suppression ciblée préservant les projets voisins.36/36 tests verts sur Node 24.
Cette PR introduit-elle un breaking change ?
Non.