fix(client): use bundled ri icon for deployment sources - #2653
Open
KepoParis wants to merge 1 commit into
Open
Conversation
3 tasks
|
0 New Issues
0 Fixed Issues
0 Accepted Issues
Contributor
|
🤖 Hey ! A preview of the application is available at : https://console-pr-2653.dso.cpin-hp.numerique-interieur.fr Please be patient, deployment may take a few minutes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues liées
Issues numéro: #2652
Quel est le comportement actuel ?
DeploymentCard.vueaffiche l'icônemdi:gitdevant chaque source de déploiement. C'est la seule icônemdi:du client, etsrc/icon-collections.tsn'embarque que des icônesri(@iconify-json/riest le seul paquet d'icônes du client). L'icône dépend donc de l'API Iconify au runtime et ne s'affiche pas sans accès sortant.Quel est le nouveau comportement ?
La carte utilise
ri:git-repository-line, qui est ajoutée àsrc/icon-collections.tsavec son aliasgitRepositoryLine. Plus d'appel réseau, et le glyphe correspond au texte qu'il précède, le nom du dépôt suivi de la révision.Le set
rin'a pas de logo Git, j'ai donc choisi sur le sens plutôt que sur la ressemblance avecmdi:git.ri:git-branch-linereste une alternative si vous préférez insister sur la révision.À noter :
scripts/generate-icons.shrégénèreicon-collections.tsmais utilisemktemp -p, propre à GNU, qui échoue sur macOS. J'ai édité le fichier à la main en gardant la forme et l'ordre alphabétique produits par le script.Cette PR introduit-elle un breaking change ?
Non.
Autres informations
Aucune.