Support automatic OAuth client-credentials token refresh - #838
Open
chrisrentsman wants to merge 2 commits into
Open
Support automatic OAuth client-credentials token refresh#838chrisrentsman wants to merge 2 commits into
chrisrentsman wants to merge 2 commits into
Conversation
Contributor
|
@PierreBtz this is in reference to #829. (heh, Captain obvious here. I missed the reference that is clearly at the top of the PR description :-D ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for Zendesk's OAuth
client_credentialsgrant so aZendeskclient can mint and refresh short-lived access tokens instead of requiring a pre-minted OAuth token.Addresses #829.
Changes
Commit 1: Base implementation
HttpTokenMinterclass for minting OAuth tokens, taking care to prevent credential leaks.SharedFutureTokenProviderclass for handling thread-safe token caching and refresh.Zendesk.Builderconfiguration.Zendesk#warmUp()for clients who would like to mint the OAuth token ahead of the first request.ZendeskOAuthExceptionwhen no usable token remains.Commit 2: Add backoff on refresh failures
SharedFutureTokenProviderto suppress proactive mint attempts for 10 seconds after a failed mint attempt while a usable cached token remains.Validation
mvn verifyusing JDK 11.References: