Skip to content

brats: run syslog-forwarder under bpm - #2803

Merged
mkocher merged 1 commit into
mainfrom
resolute-pipeline
Aug 13, 2026
Merged

brats: run syslog-forwarder under bpm#2803
mkocher merged 1 commit into
mainfrom
resolute-pipeline

Conversation

@mkocher

@mkocher mkocher commented Aug 13, 2026

Copy link
Copy Markdown
Member
  • this is necessary to get brats passing on Resolute
  • it's ok for it to run under BPM on all stemcell lines, since we're controlling the manifest and there will not be other copies of BPM to conflict
  • up the compile timeout a little, hopefully 30 minutes is enough even when when CI is overloaded

What tests have you run against this PR?

None, need to test it in CI

Does this PR introduce a breaking change?

No

- this is necessary to get brats passing on Resolute
- it's ok for it to run under BPM on all stemcell lines, since we're
  controlling the manifest and there will not be other copies of BPM to
  conflict
- up the compile timeout a little, hopefully 30 minutes is enough even when
  when CI is overloaded
@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 7a836b56-882a-4769-9812-7ef6934d603a

📥 Commits

Reviewing files that changed from the base of the PR and between 3351c05 and e097006.

📒 Files selected for processing (4)
  • ci/shared/brats/test-acceptance.yml
  • src/brats/acceptance/blobstore_test.go
  • src/brats/assets/syslog-manifest.yml
  • src/brats/utils/utils.go

Walkthrough

The change updates acceptance deployments to upload syslog-release version 12.3.27 and bpm-release version 1.4.36. The syslog manifest adds the BPM release, adds the BPM job to syslog_forwarder, and enables BPM usage. The default START_INNER_BOSH_TIMEOUT increases from 25m to 30m in the acceptance configuration and Bootstrap.

Mergeability Score: ⚪ Minimal · up to e0970

The PR adjusts syslog-forwarder process management and the acceptance-test compile timeout; no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the purpose and breaking-change status, but it omits required context, release notes, team tags, and AI feedback sections. Add the missing template sections and provide contextual links, BOSH release notes, team tags, and AI review feedback status.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the primary change: running the syslog forwarder under BPM in BRATs.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch resolute-pipeline

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-project-automation github-project-automation Bot moved this from Inbox to Pending Merge | Prioritized in Foundational Infrastructure Working Group Aug 13, 2026
@mkocher
mkocher merged commit adbbea8 into main Aug 13, 2026
22 checks passed
@mkocher
mkocher deleted the resolute-pipeline branch August 13, 2026 22:22
@github-project-automation github-project-automation Bot moved this from Pending Merge | Prioritized to Done in Foundational Infrastructure Working Group Aug 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants