feat(plugins): remove obsolete global.greenhouse OptionValues

[mikolajkucinski]

Description

global.greenhouse.clusterNames and global.greenhouse.teamNames are injected into every Plugin and consumed by none(every Helm values file carries the full list of clusters and teams). They are no longer injected, and are stripped from Plugins that already have them persisted in .spec.optionValues.

An expression referencing either value stops the Plugin from reconciling, a chart template ranging over them renders nothing. Migrate to global.greenhouse.clusterName and global.greenhouse.metadata.*.

spec.values changes on every existing HelmRelease.

What type of PR is this? (check all applicable)

• 🍕 Feature
• 🐛 Bug Fix
• 📝 Documentation Update
• 🎨 Style
• 🧑‍💻 Code Refactor
• 🔥 Performance Improvements
• ✅ Test
• 🤖 Build
• 🔁 CI
• 📦 Chore (Release)
• ⏩ Revert

Related Tickets & Documents

• Closes [FEAT] - Remove obsolete global.greenhouse OptionValues #1959

Added tests?

• 👍 yes
• 🙅 no, because they aren't needed
• 🙋 no, because I need help
• Separate ticket for tests # (issue/pr)

Added to documentation?

• 📜 README.md
• 🤝 Documentation pages updated
• 🙅 no documentation needed
• (if applicable) generated OpenAPI docs for CRD changes

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• My changes generate no new warnings
• New and existing unit tests pass locally with my changes

[Copilot]

Pull request overview

Removes the obsolete global.greenhouse.clusterNames and global.greenhouse.teamNames Helm option values from being generated/injected, and ensures any already-persisted instances are stripped from Plugins/templating flows. The PR also updates documentation to reflect the reduced injected value set and adds regression tests to cover the new behavior.

Changes:

• Stop generating/injecting global.greenhouse.clusterNames and global.greenhouse.teamNames, and strip them if already present in .spec.optionValues.
• Add test coverage for “not injected”, “stripped”, and “no mutation” behaviors.
• Update user/reference/contributor docs with the new injected-value set and migration warnings.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
internal/helm/values.go	Removes generation of the retired values and strips them from merged option values.
internal/helm/helm_test.go	Updates/extends unit tests to assert retired values are not generated/injected and are stripped safely.
internal/cmd/plugin_template.go	Strips retired values from rendered preset values during templating.
internal/cmd/plugin_template_test.go	Adds coverage ensuring retired values in presets are not rendered.
docs/user-guides/plugin/metadata-expressions.md	Removes retired vars from the list and adds a migration warning.
docs/reference/components/pluginpreset.md	Removes retired vars from reference and adds a migration warning.
docs/reference/components/plugin.md	Documents the injected Greenhouse values and the removal warning.
docs/contribute/plugins.md	Updates contributor docs to reflect the reduced injected value set and links to reference docs.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.