Skip to content

fix(generic): isolate dynamicgo annotation mapper options - #1990

Merged
wdp2020 merged 4 commits into
cloudwego:mainfrom
wdp2020:fix/dynamicgo-annotation-mapper-isolation
Aug 28, 2026
Merged

fix(generic): isolate dynamicgo annotation mapper options#1990
wdp2020 merged 4 commits into
cloudwego:mainfrom
wdp2020:fix/dynamicgo-annotation-mapper-isolation

Conversation

@wdp2020

@wdp2020 wdp2020 commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

What type of PR is this?

  • Fix a panic caused by concurrent access to DynamicGo's global annotation mapper registry.
  • Upgrade DynamicGo from v0.8.0 to v0.9.2.
  • Configure the go.tag annotation mapper on each DynamicGo thrift.Options instance instead of modifying the global registry.
  • Prevent providers with different WithGoTagDisabled settings from affecting each other.
  • Add a regression test covering mapper isolation and ensuring the global mapper remains unchanged.

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@wdp2020
wdp2020 requested review from a team as code owners August 21, 2026 08:37
@codecov

codecov Bot commented Aug 21, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.11%. Comparing base (8bb270e) to head (f7e7881).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
pkg/generic/thriftidl_provider.go 81.81% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1990      +/-   ##
==========================================
+ Coverage   62.95%   63.11%   +0.15%     
==========================================
  Files         394      396       +2     
  Lines       30267    30369     +102     
==========================================
+ Hits        19056    19166     +110     
+ Misses       9924     9920       -4     
+ Partials     1287     1283       -4     
Flag Coverage Δ
integration 51.84% <0.00%> (-0.03%) ⬇️
unit 53.77% <81.81%> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wdp2020
wdp2020 merged commit aaa9183 into cloudwego:main Aug 28, 2026
42 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants