Note that CloudX banner refresh can also be disabled server-side - #10
Merged
Merged
Conversation
StopBannerAutoRefresh was presented as the only way to keep the SDK's refresh timer out of the pass cycle. A banner or MREC ad unit whose refresh rate is 0 in the CloudX dashboard also reaches the SDK as refresh-disabled at init, so say so, and say why the call stays: it makes the cycle independent of how the unit happens to be configured.
There was a problem hiding this comment.
🟢 Approval recommended
The change is comment-only, consistent with surrounding documentation style, and does not affect runtime behavior.
Pull request overview
Updates the inline documentation in FirstLookBannerController.CloudXCreateAndLoad() to clarify that CloudX banner auto-refresh can be disabled not only via CloudXSdk.StopBannerAutoRefresh(...), but also server-side via ad unit configuration (refresh rate = 0), while explaining why the explicit SDK call is still kept to make the lifecycle deterministic.
Changes:
- Expanded the comment above
CloudXSdk.StopBannerAutoRefresh(_cloudXAdUnitId);to mention server-side refresh-disable behavior. - Documented why the explicit stop call remains valuable (configuration-independent, no-op when already disabled).
File summaries
| File | Description |
|---|---|
| Assets/Scripts/FirstLook/FirstLookBannerController.cs | Comment-only clarification about CloudX banner refresh being disable-able via dashboard config as well as via SDK call. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The First Look banner controller called
CloudXSdk.StopBannerAutoRefreshand explained the ordering againstCreateBanner, but read as if that call were the only way to keep the SDK's refresh timer out of the pass cycle.It is not. A banner or MREC placement with Disable auto-refresh ticked in the CloudX dashboard is emitted to the SDK as
bannerAutoRefreshDisabled: truein the init response, and neither platform starts a refresh timer for such a unit (AndroidAdViewManagerskipsstartRefreshLoop(); iOSCLXPublisherAdViewinitialisesautoRefreshEnabledtoNO).This adds that to the comment above the call, and says why the call stays regardless: it makes the cycle independent of how the ad unit happens to be configured, and it is a no-op on a unit that already has refresh off.
Comment only — no behaviour change.