ci: mask the AWS account ID in job logs - #29
Merged
Merged
Conversation
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
There was a problem hiding this comment.
🟢 Approval recommended
Both credential steps use the supported masking input without altering functional behavior.
Pull request overview
Adds explicit AWS account ID masking to public CI logs.
Changes:
- Enables account ID masking in both AWS credential steps.
- Preserves existing action pins and workflow behavior.
File summaries
| File | Description |
|---|---|
.github/workflows/eif-build.yml |
Masks the account ID during EIF build authentication. |
.github/workflows/docker.yml |
Masks the account ID during ECR publishing authentication. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This repository is public, so its job logs are public. The AWS account ID reaches those logs through the ECR registry hostname and through the role ARN the credentials step assumes.
Today the ID is masked only as a side effect of being carried in the
AWS_ACCOUNT_IDrepository secret, which GitHub redacts wherever the secret's own value appears.aws-actions/configure-aws-credentialsdoes not mask the account ID by default, so anything the action or a later step derives and prints — an assumed-role ARN, a caller identity, an ECR registry the action itself resolves — is not covered by that redaction.mask-aws-account-id: trueregisters the account ID as a masked value for the rest of the job, so those derived forms stay masked too. Added to bothconfigure-aws-credentialssteps in the repository:.github/workflows/docker.ymland.github/workflows/eif-build.yml. No other behavior changes; the ratchet pins and their comments are untouched.Pre-merge checklist
Ratchet Lint:mise run //:ratchet:lint, andmise run //:ratchet:pinleaves no diff)Ratchet Lint,lint,testall pass on 9f6b752)Post-deploy/apply verification
main-branch run after merge showsmask-aws-account-id: trueamong the credentials step's inputs in the log (Docker Build run 35112420899 on c2abdde: input line(s) present)gh run view <id> --logfor that run contains no unmasked occurrence of the account ID (run 35112420899: zero matches for the raw account ID, ECR hostnames and ARNs render as ***)🤖 Generated with Claude Code