fix(go-tools): blind-validation fixes; v0.3.1 (closes #11) - #13
Merged
Merged
Conversation
Blind validation per house standard 5 (issue #11): all five skills run by fresh agents against go-performance-starter@50a8fee (hit) and a minimal non-starter Go module (miss), scored against criteria pinned before any agent launched. 10/10 runs met every pinned criterion. Validation record: - templ-component-scaffold: scaffolded typed-props StatusBadge, templ generate + full task ci green; miss context stopped on the pre-fetch fallback without inventing a view layer. - test-scaffold: table-driven t.Skip stubs beside source, stdlib style, vet+test green in both contexts (miss context is the generic-Go path). - sqlc-query-scaffold: CountUsers :one appended, db:generate round-trip, repository interface + postgres adapter (RLS inScope pattern) + fake updated, build/tests green; miss context stopped on the no-sqlc fallback. - perf-budget-check: ran task test:performance, per-gate verdicts verbatim and byte-identical to the independently pinned run (binary 16341986B, JS 32771B gzipped, CSS 7678B gzipped, all green); miss context stopped and pointed at /perf-audit without running anything. - go-pr-description: master base detected, both commits covered, honest unchecked boxes with env-failure attribution; its ADR step caught a genuine ADR-027 contradiction the probe branch had accidentally seeded (unconditional left-most XFF trust) — unplanned true positive. Doc gaps found by the runs, fixed here (fix the skill, not the test): - templ-component-scaffold: named IsHTMXRequest as a render.go given; the starter ships only Render/CurrentYear — now reads the repo's actual helpers and never references an absent one. - test-scaffold: only checked <source>_test.go for existing coverage; sibling test files can already cover the target funcs — now greps the package's other _test.go files and reports instead of duplicating. - perf-budget-check: hardcoded 'git diff main' twice; the starter itself is master-based — now base-branch-aware (main or master). Closes #11 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Executes issue #11: blind validation of all five clownware-go-tools skills per house standard 5, and ships the three doc fixes the runs surfaced. Bumps go-tools 0.3.0 → 0.3.1; ROADMAP records the validation under Graduated.
Validation summary
10/10 blind runs met every criterion pinned before launch (hit context: go-performance-starter@50a8fee; miss context: a minimal non-starter Go module per skill):
task cigreenFixes (found by the runs)
IsHTMXRequestexists inrender.go(the starter ships onlyRender/CurrentYear)_test.gofiles for existing coverage of the target's functions before stubbing duplicatesmainormaster) instead of hardcodingmain— the starter itself is master-basedFull pinned ground truth and per-run reports are recorded in the release commit body.
Merge as rebase (single commit; keeps the release commit intact for plugin-release delta derivation).
🤖 Generated with Claude Code