Conversation
Contributor
Greptile SummaryThe PR restores onboarding when startup or reload finds that the configured directory or
Confidence Score: 5/5The PR appears safe to merge, with the missing-configuration recovery behavior covered by focused manager tests. The changed manager paths persist an incomplete onboarding state when configuration resources are absent, and the application observes that state to present the existing onboarding window; no concrete blocking or independently actionable non-blocking issue remains. Important Files Changed
Reviews (1): Last reviewed commit: "Show onboarding when config directory is..." | Re-trigger Greptile |
Contributor
Author
|
Note:
|
muescha
force-pushed
the
fix/no-onboarding-on-missing-config-dir
branch
from
September 16, 2026 17:20
53e330f to
3494b59
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Show onboarding when the configured configuration directory is missing.
Problem
If the saved configuration directory does not exist, startup logs an error and returns early. Because onboarding had already been marked as completed, the onboarding window is not shown and the user cannot choose a new configuration path.
Fix
Testing
Focused ManagerManagerTests passed with xcodebuild test for the Development scheme on macOS, using CODE_SIGNING_ALLOWED=NO.