Skip to content

node utils inspect and variadic console log - #216

Merged
cmsj merged 6 commits into
mainfrom
node-utils-inspect-and-variadic-console-log
Sep 11, 2026
Merged

cmsj merged 6 commits into
mainfrom
node-utils-inspect-and-variadic-console-log

Conversation

@cmsj

@cmsj cmsj commented Sep 11, 2026

Copy link
Copy Markdown
Owner
  • Update jsc-extras pin
  • Improve console.log to be more aligned with mainstream implementations, and in support of that, add our first Node.js compatibility feature - util.inspect()

…s, and in support of that, add our first Node.js compatibility feature - util.inspect()
@cmsj cmsj self-assigned this Sep 11, 2026
@greptile-apps

greptile-apps Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Adds an initial Node.js compatibility layer and improves console argument formatting.

  • Registers util as a built-in CommonJS module and implements util.inspect().
  • Makes console logging methods variadic and formats non-string arguments through the new inspector.
  • Updates documentation extraction and generation to represent variadic JSExport methods.
  • Pins a newer javascript-core-extras revision.

Confidence Score: 5/5

The changes since the previous review appear safe to merge, with no new actionable findings.

The invalid-date and variadic-declaration findings were fixed, all previous root threads were manually resolved, and the recent documentation-generator changes correctly propagate rest-parameter metadata without establishing a new failure.

Important Files Changed

Filename Overview
Hammerspoon 2/Modules/node/NodeModuleUtil.swift Implements value inspection and adds descriptor-based handling intended to avoid invoking own-property getters.
Hammerspoon 2/Modules/console/ConsoleModule.swift Makes console methods variadic at runtime and adds metadata for generated declarations.
Hammerspoon 2/Engine/require.js Resolves registered built-in module names before attempting filesystem resolution.
Hammerspoon 2/Modules/node/NodeModuleRegistry.swift Installs the native util module in the JavaScript context.
scripts/extract-docs.js Parses variadic-method markers and propagates rest-parameter metadata to generated documentation.
scripts/generate-html.js Includes rest-parameter notation in generated search entries.

Reviews (2): Last reviewed commit: "Protect util.inspect against invalid dat..." | Re-trigger Greptile

Comment thread Hammerspoon 2/Modules/node/NodeModuleUtil.swift
Comment thread Hammerspoon 2/Modules/node/NodeModuleUtil.swift
Comment thread docs/hammerspoon.d.ts Outdated
@cmsj

cmsj commented Sep 11, 2026

Copy link
Copy Markdown
Owner Author

@greptile

@cmsj
cmsj merged commit 04378bb into main Sep 11, 2026
1 of 3 checks passed
@cmsj
cmsj deleted the node-utils-inspect-and-variadic-console-log branch September 11, 2026 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant