revert console to text - #220
Merged
Merged
Conversation
cmsj
commented
Sep 12, 2026
Owner
- Explicitly mark our XPC helper as not being a UI app
- Revert Console window to using a Text field
Contributor
Greptile SummaryThis PR marks the AppleScript XPC helper as a non-UI process and consolidates console output into one attributed text container so users can select text across log entries.
Confidence Score: 4/5The PR appears safe to merge, with a non-blocking issue where already-rendered timestamps can remain stale after system formatting settings change. The helper configuration is consistently applied, and the new console rendering preserves log updates and bottom scrolling; the only accepted issue is incomplete cache invalidation for runtime locale, time-zone, or calendar changes. Files Needing Attention: Hammerspoon 2/Windows/ConsoleView.swift Important Files Changed
Prompt To Fix All With AI### Issue 1
Hammerspoon 2/Windows/ConsoleView.swift:208-209
**Cached timestamps become stale**
When the system locale, time zone, or calendar changes while the console remains open, `formatEntry` uses the updated setting but `displayedEntries` does not change. The cached attributed string is therefore not rebuilt, so existing timestamps continue to use the old formatting until the log entries change. Observe the relevant setting changes or include these formatting inputs in the cache invalidation.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Reviews (1): Last reviewed commit: "Revert Console window to using a Text fi..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.