ci(license-exceptions): make the decision workflow record decisions faithfully - #1513
Merged
Conversation
…ithfully Rename license-exception-approved.yml to license-exception-decision.yml; it has handled denied and not-eligible outcomes since 69bbe5b. Parsing now matches the 5-column issue template exactly: - Project Usage URL (col 3) is folded into scope as '(used at: <url>)' instead of being discarded; the phantom 6th 'comment' column and the dead scope-regex fallback are removed. - Rows missing Component or License(s) are skipped and reported; a run that parses zero rows comments on the issue and fails instead of opening an empty PR. - approvedDate uses the issue's close date when it is already closed, so the recorded date is the decision date rather than the label date. - IDs continue from existing exc-<date>-NNN entries, avoiding same-day collisions that would fail validate-exceptions. - results is written alongside issueUrl; the site and all existing rows read results. Triage: use the same pipe-preserving cell split, update the existing 'Automated Triage Summary' comment on edits instead of posting a new one, and explain the labels and the Governing Board step. Signed-off-by: Jeffrey Sica <me@jeefy.dev>
✅ Deploy Preview for cncf-license-exceptions canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #1511 and the first real run of the decision workflow (#1512). Renames
license-exception-approved.yml→license-exception-decision.yml(it has recorded denied/not-eligible outcomes since 69bbe5b) and fixes what that first run exposed.Decision workflow
Component | Upstream URL | Project Usage URL | License(s) | Purpose. Project Usage URL was previously parsed and discarded; it is now folded intoscopeas(used at: <url>). The phantom 6th "comment" column (unreachable from the template) and the dead scope-regex fallback are removed.approvedDate= decision date. Uses the issue'sclosed_atwhen the issue is already closed, otherwise the label date. Record license exception decision (not-eligible) for OpenTelemetry (OpenTelemetry Demo, https://github.com/open-telemetry/opentelemetry-demo) (#1482) #1512 recorded 2026-09-07 for a decision made 2026-08-19; this would have produced 2026-08-19.exc-<date>-NNNentries instead of always starting at 001 (which would failvalidate-exceptionson the second decision of a day).resultsalongsideissueUrl— the site and all 494 existing rows readresults, so workflow-created rows were showing no issue link.Triage workflow
editedinstead of posting a new one each time.needs-review/possible-duplicatelabels and mentions the Governing Board step.Verification
closed_at=2026-08-19: count 1,not-eligible,exc-2026-08-19-001,packageUrl=https://github.com/grafana/k6,results === issueUrl, scope ends with(used at: …/xk6-otel/go.mod).…-003→ new ids start at-004; no table → guard comment +setFailed.Companion PRs (independent, any merge order): #1514 site rework, #1515 docs + generators.