feat(config): multi-layer config overlay (env + project) - #174
Merged
Conversation
…WebServer runWebServer was 802 lines (limit 800). Extract the notifying-handler construction into a package-level newNotifyingHandler function.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe web server now delegates shared WeChat/BLE notifier initialization and per-task notifying handler construction to dedicated helpers while preserving conditional feature enablement and notification wiring. ChangesWeb notifier wiring
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Multi-layer config overlay support: environment variable overlay (
JCODE_MODEL,JCODE_DEFAULT_MODE, etc.) and project-level config overlay (.jcode/config.json).Changes
ApplyEnvOverlayfor env-var-driven config overridesApplyProjectOverlayfor per-project.jcode/config.jsonmergesfunlenlint violation inrunWebServer(extractnewNotifyingHandler)Verification
go build ./...✓golangci-lint run— 0 issues ✓go test ./...— all pass ✓Summary by CodeRabbit