Skip to content

fix(web): theme saved SSH alias selector - #176

Merged
cnjack merged 1 commit into
mainfrom
fix/remote-alias-selector
Jul 29, 2026
Merged

fix(web): theme saved SSH alias selector#176
cnjack merged 1 commit into
mainfrom
fix/remote-alias-selector

Conversation

@cnjack

@cnjack cnjack commented Jul 29, 2026

Copy link
Copy Markdown
Owner

Summary

  • Replace the native saved SSH alias select with a theme-aware listbox.
  • Close the selector on outside click or Escape, and reset it with the wizard.
  • Show selected state and the alias connection address in each option.

Testing

  • pnpm --dir web typecheck (blocked on latest main by the unrelated web/src/app/composerHost.ts:63 ProductComposerStrings.agentTitle mismatch).

Summary by CodeRabbit

  • Enhancements
    • Replaced the saved SSH alias selector with an accessible custom dropdown.
    • Added clearer alias labels, including connection details and a “no alias” option.
    • Improved dropdown behavior with outside-click and Escape-key closing.
    • Added visual styling for open, selected, and available options.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@cnjack
cnjack merged commit da0e32a into main Jul 29, 2026
3 checks passed
@cnjack
cnjack deleted the fix/remote-alias-selector branch July 29, 2026 16:15
@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: ebe6b2ca-4948-4168-9b60-9a5ea45a6afd

📥 Commits

Reviewing files that changed from the base of the PR and between 01f2af5 and 3b8ac35.

📒 Files selected for processing (1)
  • web/src/components/RemoteConnectWizard.tsx

📝 Walkthrough

Walkthrough

RemoteConnectWizard replaces the saved SSH alias <select> with a custom listbox-style dropdown, adding selected-label derivation, outside-click and Escape dismissal, reset behavior, accessible options, and corresponding CSS styling.

Changes

Remote alias dropdown

Layer / File(s) Summary
Alias dropdown state and selection
web/src/components/RemoteConnectWizard.tsx
Adds dropdown state, selected-label derivation, outside-click and Escape handling, and closes the menu during form reset or alias application.
Accessible dropdown UI and styling
web/src/components/RemoteConnectWizard.tsx
Replaces the native select with a trigger, listbox, and selectable alias options, then adds menu, option, selected-state, and chevron styles.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

  • cnjack/jcode#126: Updates the same RemoteConnectWizard alias dropdown and remote-connection flow.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/remote-alias-selector

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant