Skip to content

update README and plugin annotation keys - #2

Open
nimakaviani wants to merge 2 commits into
mainfrom
rename-labels
Open

update README and plugin annotation keys#2
nimakaviani wants to merge 2 commits into
mainfrom
rename-labels

Conversation

@nimakaviani

@nimakaviani nimakaviani commented Jul 25, 2023

Copy link
Copy Markdown
Contributor
  • updated the annotation keys to have fully qualified names ending in cnoe.io
  • fixed the README accordingly

@nimakaviani
nimakaviani requested a review from nabuskey July 31, 2023 21:49
Comment thread README.md Outdated
- `argo-workflows.cnoe.io/cluster-name`: Optional. Specifies the name of the Kubernetes cluster to retrieve information from. If missing chooses the Kubernetes context available to backstage at runtime.

you can also use the `backstage.io/kubernetes-label-selector`, to select the
relevant spark jobs. However , `backstage.io/kubernetes-label-selector` is a

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be workflows instead of spark jobs

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants