Redesign the demo page - #5
Merged
Merged
Conversation
The page worked and looked like a default: system font, a card on a grey background, controls with no hierarchy. It now uses the same vocabulary as the other cobanov.dev pages. Film-base black, one accent spent only on things you can act on, Geist for reading and JetBrains Mono for anything measured, a sticky masthead, film grain, a base-8 spacing scale and a named type scale. The accent is the subject rather than a brand colour: a surface facing the camera encodes as rgb(128, 128, 255), so the page runs on the colour every normal map is mostly made of, and the mark is a normal-mapped sphere. Also here: - Each panel carries its own reading, the source its pixel size and the output its conversion time, in mono. The status line is left for messages. - A full head: description, canonical, OpenGraph and Twitter cards, structured data, and an OG image built from the Mars pair in the README. - `_headers`: Pages caches assets for four hours by default, which is wrong for the two files carrying the page's behaviour, and a CSP that names the three hosts the page is allowed to reach. - The sample is an 8-bit depth map, so the page opens at sigma 2 rather than showing its quantisation rings as a first impression. The note beside it explains why they appear at all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The demo worked and looked like a default: system font, a card on a grey background, controls with no hierarchy. It now speaks the same language as the other cobanov.dev pages.
rgb(128, 128, 255), so the page runs on the colour every normal map is mostly made of, and the mark is a normal-mapped sphere._headers: Pages caches assets for four hours by default, which is wrong for the two files carrying the page's behaviour, plus a CSP naming the three hosts the page may reach (jsdelivr for ONNX Runtime, Google Fonts, Hugging Face for the depth model). Verified live: no violations, and the model fetch still returns 206.Deployed and checked on depth2normal.cobanov.dev: Geist loads, the conversion runs in about 300 ms, the readouts fill in.