feat: DEVICE_AUTH_RESPONSE_FAILED is reported by the server when a re…#37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…sponse fails
Summary
Introduces
FAITH_ENVELOPE_DEVICE_AUTH_RESPONSE_FAILEDto the protocol while fixing some security issues inserver_handle_device_link_response.FAITH_ENVELOPE_DEVICE_AUTH_RESPONSE_FAILEDis sent by the server back to the client sendingFAITH_ENVELOPE_DEVICE_AUTH_APPROVEorFAITH_ENVELOPE_DEVICE_AUTH_DENYwhen handling of the envelope failed.Testing
Describe how you tested this change.
scripts/check.shpasses locally