fix(claude-sdk-oauth): fail closed after logout - #638
Open
eddieparc wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
CI note: I reran the exact file hermetically with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://linear.app/jgplabs/issue/LAB-27/claude-로그아웃-후-fallback-응답이-계속-발생함
Problem
With
tokenInjection: oauth-slots,/logoutdeletes the managed pool but the next Claude request silently falls back to ambient Claude CLI credentials. The fallback chain can therefore reportFallback model claude-sdk-oauth/... respondedeven though the user explicitly logged out.Fix
Managed
oauth-slotsandconfig-dirlanes now fail closed when their pool has no accounts. Intentionalambientmode is unchanged.Verification
npm run check: passedauthentication_failed: No Claude SDK OAuth accounts configuredSummary by cubic
Stop silent fallback to ambient Claude credentials after logout in the
claude-sdk-oauthauth lane. Requests now fail closed with a clear error when the managed account pool is empty (addresses LAB-27).oauth-slotsandconfig-dirnow throwauthentication_failed: No Claude SDK OAuth accounts configured. Add one with /claude-account add.when no accounts exist.ambientmode behavior is unchanged.Written for commit 3923f50. Summary will update on new commits.