fix(coding-agent): list PI_RULES settings in --help - #681
Open
Yoonkeee wants to merge 1 commit into
Open
Conversation
Yoonkeee
marked this pull request as ready for review
August 3, 2026 13:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PI_RULES_DISABLED,PI_RULES_MAX_RULE_CHARS, andPI_RULES_MAX_RESULT_CHARSin the top-level Environment Variables helpchanges.mdrecordCloses #678
Root cause
printHelp()maintains its Environment Variables section independently. PR #670 added the runtime settings and README rows, but did not update that static help surface. The two character limits have no equivalent CLI flags, so they were otherwise undiscoverable fromsenpi --help.RED -> GREEN
npx vitest --run test/suite/regressions/678-pi-rules-help-env.test.tsPI_RULES_DISABLEDwas absent from top-level helpVerification
npm run checknpm run build--help,-h, duplicate detection, exact defaults, and invalid environment values30188918f96d033def3eaaf48af4273512a60c42Built/source CLI observation:
Both normal and
-nehelp invocations exited 0 with empty stderr.The full coding-agent suite reached 6745 passing tests with one unrelated timing-sensitive issue #5303 assertion failing under full-suite load; that test file passed 2/2 immediately in isolation. No production behavior in that path is changed here.
Scope
CHANGELOG.mdis intentionally unchanged per repository policy.Summary by cubic
Add the
PI_RULES_DISABLED,PI_RULES_MAX_RULE_CHARS, andPI_RULES_MAX_RESULT_CHARSenv vars to the top-level--helpso users can discover and configure rule behavior. Aligns help with the runtime and README. Fixes #678.Written for commit 3018891. Summary will update on new commits.