Skip to content

V0.11.1/regression fix - #45

Open
gimlichael wants to merge 11 commits into
mainfrom
v0.11.1/regression-fix
Open

gimlichael wants to merge 11 commits into
mainfrom
v0.11.1/regression-fix

Conversation

@gimlichael

Copy link
Copy Markdown
Member

This pull request strengthens the git-remote-release skill with comprehensive release-note format validation. Introduces Python validation that enforces the structured opening contract, curated bullet format, and em dash prohibition. Adds regression tests and expands documentation to ensure consistent high-quality release notes.

Format validation:

  • Enforces opening with 'This release ' to establish structured contract
  • Validates release-highlight bullets with bold lead-ins and natural prose
  • Rejects em dashes and malformed prose paragraphs as format violations
  • Comprehensive validation failure messages guide users to correct format

Release documentation:

  • Updates CHANGELOG.md with release notes for the 0.11.1 patch version
  • Documents strengthened validation capabilities and format requirements
  • Includes structured opening and curated highlight bullets

Skill specification:

  • Restructures SKILL.md with dedicated Non-Negotiable Rules section
  • Clarifies structured opening format and curated release-highlight pattern
  • Documents em dash prohibition as explicit format constraint
  • Enhances Data Collection Strategy with bundled collector and validation workflow

Skill documentation:

  • Updates README.md to emphasize structured release-note format requirements
  • Highlights 'This release ...' opening and dash-bullet format in feature list
  • Clarifies that draft verification rejects format violations and malformed openings

Test coverage:

  • Expands test suite with regression detection for format violations
  • Covers bold-paragraph rejection, bullet structure validation, and contributor attribution
  • Validates comma/period separation within curated bullets
  • Ensures collector and validation run deterministically across all format requirements

Introduces a patch release documenting strengthened git-remote-release capabilities: structured release-note opening format, curated release-highlight bullets, em dash prohibition, and deterministic verification. Enhanced Python collector validation gates check format compliance and reject malformed openings, missing bullets, unsupported punctuation patterns, and incomplete contributor attribution.
Reorganizes SKILL.md with a dedicated Non-Negotiable Rules section listing the structured opening contract, curated release-highlight bullets, and em dash prohibition. Enhances the Output Format section documenting the opening paragraph and bullet structure requirements. Adds a dedicated Em Dash Prohibition section clarifying the format constraint. Expands Data Collection Strategy with guidance on bundled collector, GitHub MCP tools, and gh CLI. Updates evals.json with enhanced expectations for the opening paragraph and bullet structure, and adds eval case #10 testing the rejection of bold-leading prose paragraphs and format violations.
Adds verify_summary() function to collect-release-evidence.py that enforces the structured release-note format contract: requires opening with 'This release ', rejects bold-leading prose paragraphs, validates release-highlight bullets with natural prose following bold lead-ins, enforces comma separation between non-final bullets and periods on final bullets, and prohibits em dashes. Expands test-release-evidence.py with comprehensive coverage including test_summary_structure_rejects_bold_paragraph_regression() for format regression detection and test_summary_structure_requires_bullets_and_natural_bold_leads() for bullet structure validation. Updates draft() helper to reflect required format structure.
Updates the git-remote-release skill description in the Available Skills table to emphasize the structured release-note format: opening summary line begins with 'This release ', followed by curated dash bullets with bold lead-ins and natural prose, with optional GitHub alert blocks and verified Sources entries. Updates the skill's feature list to highlight the release-story structure requiring the 'This release ...' opening and dash-bullet format, and strengthens the strict format constraint to clarify em dash prohibition in authored release-note prose. Clarifies that draft verification rejects malformed openings, missing highlight bullets, format violations, and incomplete contributor attribution.
@gimlichael gimlichael self-assigned this Sep 25, 2026
@greptile-apps

greptile-apps Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

[Medium risk] Updates release-note format rules and verification logic.

The PR appears safe to merge based on the changes since the previous review.

Summary

The PR adds structured release-note validation and regression coverage, updates release documentation, clarifies automatic PR approval behavior, and adds two skill hero images. The changes since the previous review do not establish a new actionable issue.

Reviews (5) · Last reviewed commit: "📝 add hero images to skill documentatio..."

Comment thread skills/git-remote-release/scripts/collect-release-evidence.py Outdated
Comment thread skills/git-remote-release/scripts/collect-release-evidence.py Outdated
Comment thread skills/git-remote-release/scripts/collect-release-evidence.py Outdated
Comment thread skills/git-remote-release/scripts/test-release-evidence.py
Tighten validation rules to reject punctuation-only bullets, enforce em-dash prohibition in authored prose while preserving source titles, restrict GitHub alert blocks to supported markers only, and add comprehensive test coverage for these stricter requirements. Scope em-dash check to authored lines only, allowing exact source titles to preserve their original formatting.
Clarify release-note validation rules in README skill descriptions: em-dash prohibition applies to authored prose only, GitHub alert blocks must use only supported markers, and release-highlight bullets require explanatory prose after bold lead-ins. Align documentation with implementation improvements.
Comment thread skills/git-remote-release/scripts/collect-release-evidence.py
Comment thread skills/git-remote-release/scripts/collect-release-evidence.py Outdated
Comment thread skills/git-remote-release/scripts/collect-release-evidence.py
Update repository policy (AGENTS.md) and user-facing documentation (README.md) to clarify that same-request yolo/auto in git-remote-pr skips the approval wait but still shows the preview as status only.
Update skill instructions (SKILL.md) and corresponding eval cases (evals.json) to reflect clarified yolo/auto behavior: preview is shown as status only, no approval phrase is required or awaited.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants