PMX: Restructure obtainment, add format skills, tighten CI

[codebend3r]

Behavior-preserving structural cleanup of the obtainment feature — one commit per finding from a code-quality audit of #5. The branch also picked up the repo's commit/PR format skills, a CI pass, and a husky fix; see Notes on that scope.

Obtainment restructure

• generations.ts now owns REGIONS + REGION_OF_VERSION_GROUP; ObtainMethods.tsx drops VG_REGION, REGION_ORDER, REGION_LABELS, and GAMES_BY_REGION derives from it
• kills the getGen(gen).region fallback — a second source of truth that was wrong for every remake, which is why VG_REGION existed as a patch table
• useObtainData returns one ObtainState union (idle / loading / error / ready), replacing {data, loading, error} plus the view's compensating loading || (enabled && !data && !error)
• ObtainMethods goes from five props to two; the ready branch splits into ObtainRegions so the data is non-null by type
• Set<string> | null expansion state becomes plain useState<Set<string>> — the default region is known at mount inside ObtainRegions
• CONDITION_PREFIXES, conditionMeta's if-chain, and LEGEND_CONDITIONS collapse into one CONDITION_FAMILIES table; the legend derives from it instead of restating icon and color by hand
• RODS deleted in favor of ROD_METHODS, exported from @/obtain/pokeapi and shared by the build parser and the chip renderer
• display vocabulary moves to src/obtain/labels.ts; ObtainMethods.tsx drops from 410 lines to 176 of rendering
• ObtainMethod derives from a new OBTAIN_METHODS list and isObtainFile validates game and entry shape against it — the renderer previously indexed METHOD_LABEL on unvalidated strings
• dead clause dropped from encountersToEntries: nothing in METHOD_MAP maps to 'special', so the second half of method === 'special' && !METHOD_MAP[slug] could never be false when the first was true

Commit and PR format skills

• CLAUDE.md has mandated a commit-format skill since e1a3761, but no file existed at the path it named — the rule was unenforceable
• both skills now live in .claude/skills/, not ~/.claude/skills/, so they travel with the repo
• the commit skill is named commit-format, not pokemax-commit-format — the repo name is redundant inside the repo
• its rules were measured from the last 60 commits: 188 body bullets, 0 ending in a period, 0 prose lines, subject median 53 chars
• create-pull-request fixes the body contract: a lede, then per-subsystem sections, then verification and notes
• both mandate a PMX: repo-code prefix on every commit subject and PR title, following the sister repo's CJR: form
• both require -F - / --body-file over -m / --body: backticks inside a double-quoted shell string are executed, and this repo backticks nearly every identifier
• CLAUDE.md previously pointed the commit skill at PR titles too; that bullet now scopes to commits, and a second bullet hands PRs to create-pull-request
• AGENTS.md pointed at ~/.Codex/skills/pokemax-commit-format/SKILL.md, which never existed; it now names the repo-local file

GitHub Actions

• ci.yml ran on both push: branches: ['**'] and pull_request, so every commit on a PR branch triggered two identical full runs — push now scopes to main
• bun-version: latest made CI non-deterministic; both workflows pin 1.4.0, matching the local toolchain and the existing .nvmrc / engines pinning style
• actions/cache@v4 added on ~/.bun/install/cache, keyed by bun.lock
• ci.yml gains permissions: contents: read; it inherited the repo default and needs no write scope
• timeout-minutes on all three jobs, workflow_dispatch on ci.yml, and the concurrency group now keys on github.workflow
• workflow-level names gain emoji to match the jobs and steps, which already had them

Husky fix

• .husky/pre-commit blocked any commit staging only .md, .svg, or .png
• oxfmt exits 2 when no staged file is a type it formats, and husky runs hooks under set -e, so the bare unformatted=$(…) assignment inherited that 2
• || true on the assignment restores the intent: nothing formattable means nothing to reformat
• latent since the hook was written; it surfaced only once bun install recreated .husky/_ and the hooks began running at all

Verification

• bun run system-check green — oxfmt --check clean on 128 files, tsc -b silent, oxlint silent, vite build ok
• 143 tests passed, 2 skipped, across 29 files; three new test files (regions, obtainLabels, obtainTypes)
• isObtainFile: all 1351 files in public/obtain/ still pass the tightened guard
• CONDITION_FAMILIES: old vs new implementations diffed over all 341 distinct condition slugs in the dataset — 0 differences in label, icon, or color
• no public/obtain/ regeneration and no data changes
• history rewrite verified content-neutral: git diff between the pre-rewrite tag and the rewritten tip is empty
• the workflow changes cannot be verified until they run on GitHub; both files were parsed and every job and step confirmed named

Notes

• This branch now spans two unrelated subsystems. The obtainment restructure and the tooling work (skills, CI, husky, CLAUDE.md) share no files. Splitting the tooling commits onto their own branch would review better; left as one branch because the tooling was requested while this one was open.
• all 14 commits were rewritten to carry the PMX: prefix and the branch force-pushed, with explicit approval
• revised one audit finding mid-flight: the audit said to reuse useExpandedRegions for the region collapse state, but that hook persists to localStorage, so one Pokémon's open region would carry onto the next, whose regions are a different set. Plain useState instead, with a comment saying why.
• deploy.yml keeps its own test step even though CI now covers main — workflow_dispatch can ship a commit CI never gated
• CI checks were not split into parallel jobs: each job would re-install dependencies, and for a suite this size the sequential single job is cheaper in minutes and wall-clock
• GameId 'lets-go' is the one id that isn't its PokéAPI version-group slug; that divergence is now one named entry in trainers.ts instead of spread across region tables. Renaming it would touch trainer data, routes, and stored prefs — left alone.
• adjacent, not fixed here: scripts/ is in no tsconfig include, so build-obtain-data.mts is never type-checked by tsc -b
• docs/superpowers/plans/2026-07-31-obtainment-methods.md still cites the old skill name and is left alone — it records what was true when it was written
• this branch and PR exist because they were explicitly requested; CLAUDE.md otherwise says commit straight to main

[netlify]

✅ Deploy Preview for thepokemax ready!

Name	Link
🔨 Latest commit	9c4fa66
🔍 Latest deploy log	https://app.netlify.com/projects/thepokemax/deploys/6a8a051e400e890008f0cea0
😎 Deploy Preview	https://deploy-preview-6--thepokemax.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
🤖 Make changes	Run an agent on this branch

---

To edit notification comments on pull requests, go to your Netlify project configuration.