chore: bump parent version to 15.8.0 - #16
Merged
Merged
Conversation
fess 15.8.0 added a search-role prefix check to SystemHelper#init(), which reads role.search.user.prefix, role.search.group.prefix, role.search.role.prefix and role.search.denied.prefix. The stub FessConfig in CustomSystemHelperTest did not answer those getters, so they fell through to an uninitialized SimpleImpl and the DI container failed to initialize with an NPE from ObjectiveConfig#get. Give the stub the values fess_config.properties ships, the same way Fess's own SystemHelperTest builds a prefix config.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Locks onto the released fess-parent 15.8.0.
fess 15.8.0 added a search-role prefix check to
SystemHelper#init(), which readsrole.search.{user,group,role,denied}.prefix. The stubFessConfiginCustomSystemHelperTestdid not answer those getters, so they fell through to an uninitializedSimpleImpland the DI container failed to initialize with an NPE fromObjectiveConfig#get. The second commit gives the stub the valuesfess_config.propertiesships, the same way Fess's ownSystemHelperTestbuilds a prefix config.