fix: ConcurrentModificationException when accessing DFS referrals - #85
Open
ishmeister wants to merge 1 commit into
Open
fix: ConcurrentModificationException when accessing DFS referrals#85ishmeister wants to merge 1 commit into
ishmeister wants to merge 1 commit into
Conversation
Fixes java.util.ConcurrentModificationException when accessing DFS referral data. Refs: - codelibs#76
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SmbTreeImpl caches DFS referrals in a plain HashMap. getTreeReferral reads it by iterating the key set to find the entry whose path prefix matches the request, and setTreeReferral writes to it with put.
Neither is synchronized, and a tree connection is shared by every thread that works on the same share, so one thread can iterate the map while another caches a referral into it. The iteration then fails with ConcurrentModificationException.
Refs: