fix(editor): make global hotkeys work from panels by fcoury · Pull Request #160 · codersauce/red

fcoury · 2026-07-26T23:41:43Z

Focused plugin panels currently intercept normal-mode keymaps before editor commands can run. That leaves built-in shortcuts such as Ctrl-p and Ctrl-z unavailable in Neo-tree, while the blanket allowance for plugin commands and nested prefixes can expose commands that are not safe or meaningful from a panel.

This change introduces an explicit command scope for panel-safe dispatch:

admit panel-safe built-in actions such as file/command pickers, suspend, diagnostics, and window management
add plugin command metadata with an editor default and explicit global opt-in
mark bundled workspace pickers, pane toggles, Agent commands, Git dashboard, and symbol launchers as global
filter nested keymaps to global leaves so contextual sibling commands cannot leak through
preserve unmodified row-panel keys, including Neo-tree file operations, ahead of user-defined global bindings
document the new plugin command scope in docs/PLUGIN_API.md and docs/PLUGIN_SYSTEM.md

How to Test

Open Neo-tree with Ctrl-e, keep focus in the tree, and press Ctrl-p. The file picker should open.
From a focused panel, verify Ctrl-z, F1, and Ctrl-w w still invoke their application/window actions.
In Neo-tree, verify unmodified file-operation keys such as x remain panel-local even if the normal keymap assigns that key to a global action.
Run:
- cargo test --all-targets --all-features
- cargo clippy --all-targets --all-features -- -D warnings

fcoury · 2026-08-04T18:49:50Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6b6d92e992

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

fcoury · 2026-08-04T19:08:47Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ac02678b72

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

fcoury · 2026-08-04T19:16:39Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a894fead3d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

fcoury · 2026-08-04T19:27:16Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d29d0874b8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

fcoury · 2026-08-04T19:36:34Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fc72e9861d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

fcoury · 2026-08-04T19:49:12Z

@codex review

fcoury · 2026-08-04T20:00:12Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b0e627e8e9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

fcoury · 2026-08-04T20:16:56Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0aed426d05

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

fcoury · 2026-08-04T20:33:00Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7e7ed96a44

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-08-04T20:38:08Z

+            StmtKind::Loop { body } | StmtKind::Block(body) => {
+                self.visit_statements(&body.stmts);
+            }


Preserve metadata bindings across nested scopes

When a red_api = "^0.6.0" package stores scoped command metadata in an outer local and then shadows that local inside a nested block before calling red::add_command with the outer value, this visitor leaves the shadow's false entry in command_metadata_bindings after the block. The later call is then treated as scope-free, so the manifest check accepts a package that still uses 0.7-only scope metadata and older 0.6 hosts will reject it. Saving/restoring bindings when entering block-like statements would keep the scope check aligned with Husk's lexical shadowing.

Useful? React with 👍 / 👎.

fcoury force-pushed the feat/global-panel-hotkeys branch from 9edd3ed to 6a94a0d Compare July 26, 2026 23:44

fcoury force-pushed the feat/global-panel-hotkeys branch from 6a94a0d to 6b6d92e Compare August 4, 2026 18:33

chatgpt-codex-connector Bot reviewed Aug 4, 2026

View reviewed changes

Comment thread src/editor.rs Outdated

chatgpt-codex-connector Bot reviewed Aug 4, 2026

View reviewed changes

Comment thread src/editor.rs

chatgpt-codex-connector Bot reviewed Aug 4, 2026

View reviewed changes

Comment thread src/editor.rs

chatgpt-codex-connector Bot reviewed Aug 4, 2026

View reviewed changes

Comment thread src/plugin/runtime.rs

chatgpt-codex-connector Bot reviewed Aug 4, 2026

View reviewed changes

Comment thread src/editor.rs Outdated

fcoury added 8 commits August 4, 2026 16:56

fix(editor): make global hotkeys work from panels

76fa7cd

fix(editor): preserve meta panel hotkeys

6e3c6b9

fix(editor): preserve panel-local controls

8526f9d

almanac: document scoped panel hotkeys

98c34d5

fix(editor): preserve row panel shortcuts

ac2da59

fix(plugins): version command scope API

d2fe4d4

fix(plugins): activate scoped lazy commands

5486480

fix(plugins): align catalog API compatibility

b0e627e

fcoury force-pushed the feat/global-panel-hotkeys branch from 8e750d5 to b0e627e Compare August 4, 2026 19:59

chatgpt-codex-connector Bot reviewed Aug 4, 2026

View reviewed changes

Comment thread src/plugin/package.rs

fix(plugins): enforce command scope API

0aed426

chatgpt-codex-connector Bot reviewed Aug 4, 2026

View reviewed changes

Comment thread src/plugin/api.rs Outdated

Comment thread src/editor.rs Outdated

fix(plugins): close command scope gaps

7e7ed96

chatgpt-codex-connector Bot reviewed Aug 4, 2026

View reviewed changes

fcoury merged commit 931b7a0 into master Aug 6, 2026
24 checks passed

fcoury deleted the feat/global-panel-hotkeys branch August 6, 2026 00:58

Uh oh!

Conversation

fcoury commented Jul 26, 2026

How to Test

Uh oh!

fcoury commented Aug 4, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

fcoury commented Aug 4, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

fcoury commented Aug 4, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

fcoury commented Aug 4, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

fcoury commented Aug 4, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

fcoury commented Aug 4, 2026

Uh oh!

fcoury commented Aug 4, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

fcoury commented Aug 4, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

fcoury commented Aug 4, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Aug 4, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant