feat(languages): support static injections and scalable pack validation - #176
Merged
Conversation
Collaborator
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Arborium-backed language packs commonly describe embedded languages with static Tree-sitter query properties, but Red previously recognized only dynamic language captures. Red also rebuilt and revalidated the entire language registry after accepting every language definition, making startup and reload increasingly expensive as the pack catalog grows.
This change prepares the editor for independently installed Arborium-backed packs:
(#set! injection.language "...")while preserving existing dynamic captures and giving explicitly configured static languages deterministic precedence.Companion language-pack importer: codersauce/red-language-packs#1.
How to Test
cargo test --lib highlighter::tests::static_injection_properties_highlight_available_nested_sourceand confirm statically selected JavaScript receives syntax highlighting inside Markdown.cargo test --lib highlighter::tests::dynamic_tree_sitter_injection_captures_remain_supportedand confirm existing dynamically selected fenced languages remain unchanged.cargo test --lib language::tests::invalid_language_does_not_remove_previously_or_subsequently_accepted_languagesand confirm only the invalid definition is quarantined.--trust-native-grammars, then runred --check-config; both independent languages should load successfully.--trust-native-grammars, then runred --check-config; expectCFG401and an explicit native-grammar approval requirement.