Fix: UI review bugs - #425
Merged
Merged
Conversation
…te orphaned Prism wrapper
… drop stale manage Prism assets
Contributor
|
ramiy
reviewed
Jul 29, 2026
| public static function render_version_switch_warning(): void { | ||
| ?> | ||
| <div id="version-switch-warning" class="notice notice-warning" style="display: none; margin-top: 20px;"> | ||
| <div id="version-switch-warning" class="notice code-snippets-notice notice-warning" style="display: none; margin-top: 20px;"> |
Contributor
There was a problem hiding this comment.
Add role="region" and aria-label here.
Contributor
There was a problem hiding this comment.
also, replace inline margin-top with margin-block-start.
Member
Author
There was a problem hiding this comment.
@ramiy Added the role and updated the CSS. What should the label be? There's already text within the element explaining what it is for.
Co-authored-by: Rami Yushuvaev <r_a_m_i@hotmail.com>
Contributor
Download and install |
sheabunge
commented
Jul 31, 2026
|
|
||
| const newUrl = buildUrl(window.CODE_SNIPPETS.urls.edit, { id: response.id }) | ||
| window.history.pushState({}, document.title, newUrl) | ||
| window.history.replaceState({}, document.title, newUrl) |
Member
Author
There was a problem hiding this comment.
I think pushState is better here – it allows the 'add new' page to remain in their history.
|
|
||
| case 'description': | ||
| return ( null === $value ) ? '' : $value; | ||
| return is_scalar( $value ) ? wp_kses_post( (string) $value ) : ''; |
Member
Author
There was a problem hiding this comment.
This conversion belongs closer to when the output is actually rendered IMO.
| public static function render_version_switch_warning(): void { | ||
| ?> | ||
| <div id="version-switch-warning" class="notice notice-warning" style="display: none; margin-top: 20px;"> | ||
| <div id="version-switch-warning" class="notice code-snippets-notice notice-warning" style="display: none; margin-top: 20px;"> |
Member
Author
There was a problem hiding this comment.
@ramiy Added the role and updated the CSS. What should the label be? There's already text within the element explaining what it is for.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recreation of #414.
Outstanding issues: