Bring AGENTS.md's migration list up to date - #148
Open
toruiwasa wants to merge 1 commit into
Open
Conversation
`AGENTS.md` opened its migration list with `There are seven migrations.` and then walked through seven. It was true when #120 wrote it and has been false since #121; there are ten on `main`. A reader following that paragraph as the map it is meant to be gets handed an inventory that is short by three, and nothing in the paragraph says so. The count goes rather than moving to ten. A sentence naming a number plus a list of that many entries is a closed claim, and the next migration makes it a contradiction — falsified by anyone adding a file, without a line of `AGENTS.md` changing. A list with no count is a map: the next migration leaves a blank in it rather than a lie. The entries themselves were never wrong, and none of them is touched here. What replaces it says whose job it is to keep the list whole, because nothing said so before and that is the likeliest reason two migrations fell out of it. The three that add neither a table nor a column are `20260822050002_profile_own_reads.sql`, `20260827124213_account_emails.sql` and `20260830092253_apply_profile_children.sql` — the first two are exactly the two that went missing, which is two out of two and so an observation rather than a cause, but it is the axis the sentence names. The eighth entry is `my_profile()` and `my_credentials()` (#14), the ninth is `account_emails(uuid[])` (#123), the tenth is `apply_profile_children()` (#128). Each is written in the shape the seven above it use: what the migration establishes, and the one decision in it that a later change could undo without noticing. The eighth is somebody else's migration described in somebody else's document, so it is as close to the surrounding register as I could manage and should be rewritten freely. The prose below the list gains one clause. It already named `my_profile()` and `my_credentials()` as how the editor reads, and stopped at "saves them with a Server Action" — which reads as though the writes go straight out of the Server Action, and that is the shape #128 replaced. It now says the child tables are written through `apply_profile_children()` in one transaction. The paragraph is not restructured, and it grows from 462 words on one line to 924. Turning it into a list would make every future entry a one-line diff and would make this diff unreadable, so it is a separate question and not a contributor's to answer. Nothing in the repository lints or tests Markdown, and `ci.yml` detects a documentation-only branch and skips the build, so there is no run to point at here.
toruiwasa
marked this pull request as ready for review
September 2, 2026 23:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AGENTS.mdopens its migration list withThere are seven migrations.and then walks through seven. There are ten. I noticed it while working on #128 and said there that I would send it on its own rather than bury it in that branch. This is that.The count is dropped rather than corrected to ten. A number plus a list of that many entries turns into a contradiction the next time somebody adds a migration; a list with no number just leaves a blank in the map. Three entries added, one clause added to the prose below the list, and no existing entry touched.
Related issue
None. Two of the three missing entries are from pull requests of mine (#139 and #147), so this is finishing my own work rather than proposing new work. Happy to open one if you would rather.
Two things worth your eye
Checklist
pnpm lintpassed, where applicable (Markdown only, nothing lints it)pnpm test:e2epassed, where applicable (Markdown only)Co-Authored-By,Generated with, or tool-attribution trailers